log: Avoid breaking single log lines over multiple lines in the log file #23104
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Before this patch, the log might be corrupted by other threads logging at the same time. For example, another RPC thread: [httpworker.1] [default wallet] keypool reserve 1296 [httpworker.1] SelectCoins() best subset: Received a POST request for / from 127.0.0.1:53732 [httpworker.3] ThreadRPCServer method=getnetworkinfo user=__cookie__ [httpworker.1] 0.78125 0.1953125 0.02441406 0.00610351 0.00305175 0.00152587 total 1.01025417
Member
|
Code review ACK fa00654e3783d5c2d93ddeb0b06f26fe2ef885d8 |
laanwj
reviewed
Sep 27, 2021
added 3 commits
September 29, 2021 18:46
Replace the outdated function name with words from the English language. Logging the function name can be toggled with -logsourcelocations.
maflcko
force-pushed
the
2109-logCont
branch
from
fad8481 to
2222c04
Compare
Contributor
sidhujag
pushed a commit
to syscoin/syscoin
that referenced
this pull request
Sep 30, 2021
…le lines in the log file 2222c04 log: Adjust coin selection log string (MarcoFalke) fa6c1e8 test: Fix typos in tests (MarcoFalke) faeae29 log: Avoid broken DEBUG_LOCKORDER log (MarcoFalke) faffaa8 log: Avoid broken SELECTCOINS log (MarcoFalke) Pull request description: Follow up to commit d8b4b30 ACKs for top commit: laanwj: re-ACK 2222c04 practicalswift: cr ACK 2222c04 Tree-SHA512: e0daf76815a1b7c4898ceffedeaf7ede093223abf709874f9a0d78c8e41551c14e8b56d055c8fdf06ec698df64e67dfc168bbd8716131b23648d1d1294fa6636
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up to commit d8b4b30