log: Remove unnecessary timing of Callbacks bench #23072
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dougEfresh
force-pushed
the
23071_remove_callback_bench
branch
from
374369e to
f6f0d78
Compare
Member
|
Code review ACK f6f0d789c52dbb1d3a447a3b7e315249a2a292ce I would suggest calling it something else than a 'refactor' in the commit and PR description as it intentionally changes the functionality of the code. |
Logging of Callbacks are no longer needed and records events that are not relevant for performance analysis.
dougEfresh
force-pushed
the
23071_remove_callback_bench
branch
from
f6f0d78 to
ab27800
Compare
dougEfresh
changed the title
Contributor
Author
Now PR and commit use the keyword |
Member
|
Thanks. re-ACK ab27800 |
jonatack
reviewed
Sep 23, 2021
sidhujag
pushed a commit
to syscoin/syscoin
that referenced
this pull request
Sep 24, 2021
Fabcien
pushed a commit
to Bitcoin-ABC/bitcoin-abc
that referenced
this pull request
Oct 17, 2022
Summary: Logging of Callbacks are no longer needed and records events that are not relevant for performance analysis. This is a backport of [[bitcoin/bitcoin#23072 | core#23072]] Test Plan: `ninja all check-all` Reviewers: #bitcoin_abc, Fabien Reviewed By: #bitcoin_abc, Fabien Differential Revision: https://reviews.bitcoinabc.org/D12245
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Logging of Callbacks are no longer needed and records times that are not relevant for performance analysis.
resolves #23071