Skip to content

Conversation

@maflcko
Copy link
Member

@maflcko maflcko commented Sep 20, 2021

Add missing test coverage

@fanquake fanquake added the Tests label Sep 20, 2021
Copy link
Member

@jonatack jonatack left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for improving our addrman test coverage.

Light code review ACK faa81f9 and ran the test

@maflcko maflcko merged commit 0c1a393 into bitcoin:master Sep 21, 2021
@maflcko maflcko deleted the 2109-testAddrmanDeser branch September 21, 2021 07:30
sidhujag pushed a commit to syscoin/syscoin that referenced this pull request Sep 21, 2021
faa81f9 test: Add addrman deserialization error tests (MarcoFalke)

Pull request description:

  Add missing test coverage

ACKs for top commit:
  jonatack:
    Light code review ACK faa81f9 and ran the test

Tree-SHA512: 8b254ba912c83473125faaf7df02a33a99840b40460bdce1486991a01de9ba6371c053354318f09b69fdc18c823bca3f2f7d341db0f8950e22d8435acbaa9cf5
Fabcien pushed a commit to Bitcoin-ABC/bitcoin-abc that referenced this pull request Oct 19, 2022
Summary:
Backport of [[bitcoin/bitcoin#23041 | core#23041]].

Depends on D12308.

Test Plan:
  ./test/functional/test_runner.py feature_addrman

Reviewers: #bitcoin_abc, PiRK

Reviewed By: #bitcoin_abc, PiRK

Differential Revision: https://reviews.bitcoinabc.org/D12310
@bitcoin bitcoin locked and limited conversation to collaborators Oct 30, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants