ci: Use clang-12 and libcxx-12 for msan #23008
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maflcko
force-pushed
the
2109-ciMsan13
branch
5 times, most recently
from
ee6d115 to
37da046
Compare
Contributor
|
Concept ACK |
maflcko
force-pushed
the
2109-ciMsan13
branch
from
37da046 to
3a35efa
Compare
Contributor
|
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers. ConflictsNo conflicts as of last run. |
maflcko
force-pushed
the
2109-ciMsan13
branch
from
3a35efa to
cc0278f
Compare
maflcko
force-pushed
the
2109-ciMsan13
branch
from
cc0278f to
b8eeea1
Compare
maflcko
force-pushed
the
2109-ciMsan13
branch
2 times, most recently
from
ce9d8a9 to
f6c359f
Compare
maflcko
force-pushed
the
2109-ciMsan13
branch
from
f6c359f to
634311d
Compare
maflcko
force-pushed
the
2109-ciMsan13
branch
2 times, most recently
from
be675bf to
cc07bb4
Compare
maflcko
pushed a commit
to maflcko/bitcoin-core
that referenced
this pull request
Mar 10, 2022
3566353 ci: remove compiled-but-unused BDB from MSAN job (fanquake) Pull request description: Self-compiled BDB was added to this job as opposed to using depends BDB [due to linking issues](bitcoin#18288 (comment)), however the compiled BDB is not actually used. Remove it for now, given we don't actually lose any coverage (note that BDB is also not currently used in the naitve MSAN fuzz job or for [OSS Fuzz](https://github.com/google/oss-fuzz/blob/master/projects/bitcoin-core/build.sh#L32) builds). In future, we can use depends BDB, however introducing it now will cause false positives, which can be fixed by upgrading the versions of Clang / LLVM we use, however upgrading to those newer versions causes other issues, which appear in standard library code, and require more involved suppressing, which can be solved in a follow up or another PR i.e bitcoin#23008. Top commit has no ACKs. Tree-SHA512: 9e8fdd95246cafa27cda7bcf0641b428d4573f6748ecdf07cc6205a64351db22ba383ec943e88a69df3694ccb9f125d994b64345a4e44fb6fea4a014504760d1
fanquake
reviewed
Mar 10, 2022
Member
|
FWIW, clang-14 is available on Ubuntu 22.04 now: |
maflcko
force-pushed
the
2109-ciMsan13
branch
2 times, most recently
from
fab9af1 to
fa0e2d6
Compare
maflcko
changed the title
maflcko
changed the title
Member
Author
|
While CI passes, I've changed this to use matching versions of clang and libcxx, since it is unclear if mismatching versions are supported. |
Member
Author
|
CI is finally green |
sidhujag
pushed a commit
to syscoin/syscoin
that referenced
this pull request
Apr 3, 2022
hebasto
added a commit
to hebasto/bitcoin
that referenced
this pull request
Feb 24, 2023
The MSan issue was fixed in llvm-10. We have been using llvm-12 since bitcoin#23008.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Run the latest sanitizers to get the most implemented features