Skip to content

Conversation

@kcalvinalvin
Copy link
Contributor

@kcalvinalvin kcalvinalvin commented Sep 16, 2021

Removes stale doc about secure_allocator being defined in allocators.h.

@fanquake fanquake added the Docs label Sep 16, 2021
@kcalvinalvin kcalvinalvin force-pushed the update-stale-allocator-comment branch from 09203bb to 5008dd8 Compare September 16, 2021 12:18
@kcalvinalvin kcalvinalvin changed the title doc: Update stale comment about secure allocators. doc: Remove stale comment for CPrivKey Sep 16, 2021
@laanwj
Copy link
Member

laanwj commented Sep 16, 2021

Thanks!
ACK 5008dd8

Copy link
Contributor

@theStack theStack left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agree that this line is not needed.

Code-review ACK 5008dd8

laanwj added a commit to bitcoin-core/gui that referenced this pull request Sep 16, 2021
5008dd8 doc: Remove stale comment for CPrivKey (Calvin Kim)

Pull request description:

  Removes stale doc about `secure_allocator` being defined in `allocators.h`.

ACKs for top commit:
  laanwj:
    ACK 5008dd8
  theStack:
    Code-review ACK 5008dd8

Tree-SHA512: eb65aff6db5b27d0db2b86f1d1dc6e066daccdaf00f7f9f95b5bee507167fcea2601316cdbd70da4ba32f1fab1e28e440a7e3cabd7b1a72c07dd20b1367361f0
@maflcko maflcko closed this Sep 16, 2021
@kcalvinalvin kcalvinalvin deleted the update-stale-allocator-comment branch September 16, 2021 13:29
@bitcoin bitcoin locked and limited conversation to collaborators Sep 18, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants