Skip to content

Conversation

@fanquake
Copy link
Member

This works around an issue when trying to use std::filesystem::remove_all with the ARM GCC on Buster. Has been split out of #20744.

See commentary starting here: #20744 (comment).
Also: https://gcc.gnu.org/bugzilla/show_bug.cgi?id=93201.

This works around an issue when trying to use `std::filesystem::remove_all`
with the ARM GCC on Buster. Has been split out of bitcoin#20744.

See comments starting here:
bitcoin#20744 (comment).
Also: https://gcc.gnu.org/bugzilla/show_bug.cgi?id=93201.
@fanquake fanquake added the Tests label Sep 16, 2021
@maflcko
Copy link
Member

maflcko commented Sep 16, 2021

We currently use gcc 8.4 for the arm guix builds. Should this be bumped to gcc 10.3?

@fanquake
Copy link
Member Author

We currently use gcc 8.4 for the arm guix builds. Should this be bumped to gcc 10.3?

To match the base GCC in Buster it'd be 10.2, however if we were doing this, I don't think it should be part of this PR. Maybe another PR separate from #20744 that takes care of the more involved build system changes. There is at least some Guix changes required for the Windows build as well.

@maflcko
Copy link
Member

maflcko commented Sep 16, 2021

@maflcko
Copy link
Member

maflcko commented Sep 16, 2021

cr ACK 252d1a7

Buster is on gcc 8.3, and it doesn't look like they are going to bump to 8.4 any time soon, so moving to the next debian release seems ok.

@fanquake
Copy link
Member Author

Buster is on gcc 8.3, and it doesn't look like they are going to bump to 8.4 any time soon, so moving to the next debian release seems ok.

Yes, GCC-8 on Buster was bumped from 8.2 to 8.3 in Feb 2019, and received it's last update in April 2019.

Copy link
Member

@hebasto hebasto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK 252d1a7, I have reviewed the code and it looks OK, I agree it can be merged.

maflcko pushed a commit to bitcoin-core/gui that referenced this pull request Sep 16, 2021
252d1a7 ci: use Debian Bullseye in ARM CI (fanquake)

Pull request description:

  This works around an issue when trying to use `std::filesystem::remove_all` with the ARM GCC on Buster.  Has been split out of #20744.

  See commentary starting here: bitcoin/bitcoin#20744 (comment).
  Also: https://gcc.gnu.org/bugzilla/show_bug.cgi?id=93201.

ACKs for top commit:
  MarcoFalke:
    cr ACK 252d1a7
  hebasto:
    ACK 252d1a7, I have reviewed the code and it looks OK, I agree it can be merged.

Tree-SHA512: ca71f5cb07fe06c1c7f0160935e667ffeb62bd6a1a89b54124b5633c5c176347a2207aaa5eca68938ed89db9778d357e42b677115d4ed386fa2d7d2ffa5025ad
@maflcko maflcko modified the milestone: Future Sep 16, 2021
@maflcko
Copy link
Member

maflcko commented Sep 16, 2021

This was merged, but not marked as merged by GitHub.

@fanquake fanquake closed this Sep 16, 2021
@fanquake fanquake deleted the use_bullseye_arm_ci branch September 16, 2021 09:17
@bitcoin bitcoin locked and limited conversation to collaborators Sep 18, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants