-
Notifications
You must be signed in to change notification settings - Fork 38.6k
ci: use Debian Bullseye in ARM CI #22994
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This works around an issue when trying to use `std::filesystem::remove_all` with the ARM GCC on Buster. Has been split out of bitcoin#20744. See comments starting here: bitcoin#20744 (comment). Also: https://gcc.gnu.org/bugzilla/show_bug.cgi?id=93201.
|
We currently use gcc 8.4 for the arm guix builds. Should this be bumped to gcc 10.3? |
To match the base GCC in Buster it'd be 10.2, however if we were doing this, I don't think it should be part of this PR. Maybe another PR separate from #20744 that takes care of the more involved build system changes. There is at least some Guix changes required for the Windows build as well. |
|
Nvm. Looks like this has been backported to gcc 8 after all: https://gcc.gnu.org/bugzilla/show_bug.cgi?id=81091#c9 |
|
cr ACK 252d1a7 Buster is on gcc 8.3, and it doesn't look like they are going to bump to 8.4 any time soon, so moving to the next debian release seems ok. |
Yes, GCC-8 on Buster was bumped from 8.2 to 8.3 in Feb 2019, and received it's last update in April 2019. |
hebasto
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ACK 252d1a7, I have reviewed the code and it looks OK, I agree it can be merged.
252d1a7 ci: use Debian Bullseye in ARM CI (fanquake) Pull request description: This works around an issue when trying to use `std::filesystem::remove_all` with the ARM GCC on Buster. Has been split out of #20744. See commentary starting here: bitcoin/bitcoin#20744 (comment). Also: https://gcc.gnu.org/bugzilla/show_bug.cgi?id=93201. ACKs for top commit: MarcoFalke: cr ACK 252d1a7 hebasto: ACK 252d1a7, I have reviewed the code and it looks OK, I agree it can be merged. Tree-SHA512: ca71f5cb07fe06c1c7f0160935e667ffeb62bd6a1a89b54124b5633c5c176347a2207aaa5eca68938ed89db9778d357e42b677115d4ed386fa2d7d2ffa5025ad
|
This was merged, but not marked as merged by GitHub. |
This works around an issue when trying to use
std::filesystem::remove_allwith the ARM GCC on Buster. Has been split out of #20744.See commentary starting here: #20744 (comment).
Also: https://gcc.gnu.org/bugzilla/show_bug.cgi?id=93201.