Skip to content

build: Drop 32-bit build configurations for MSVC #22908

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
fanquake merged 2 commits into from
Sep 11, 2021
Merged

build: Drop 32-bit build configurations for MSVC #22908

fanquake merged 2 commits into from
Sep 11, 2021

Conversation

@hebasto
Copy link
Member

@hebasto hebasto commented Sep 7, 2021

A 32-bit application for Windows in 2021 looks outdated. I'm pretty sure no one is going to run Bitcoin Core v23.0 on 32-bit Windows.

Also see #15939.

@hebasto
Copy link
Member Author

hebasto commented Sep 7, 2021

cc @sipsorcery

@practicalswift
Copy link
Contributor

practicalswift commented Sep 8, 2021 •
edited
Loading

Concept ACK

Somewhat related:

@hebasto
Copy link
Member Author

hebasto commented Sep 8, 2021 •
edited
Loading

Rebased 8c49dc2 -> 57b3c5b (pr22908.01 -> pr22908.02) on top of the recent changes in CI.

@laanwj
Copy link
Member

laanwj commented Sep 8, 2021

Concept ACK. There is no point in supporting this configuration, I'm sure it's wildly under-tested. 32-bit x86 is a museum architecture by now, and accidentally using a 32-bit build on 64-bit hardware will result in lousy performance.

@fanquake fanquake requested a review from sipsorcery September 10, 2021 06:04
@fanquake
Copy link
Member

fanquake commented Sep 10, 2021

Concept ACK - haven't / wont test though.

sipsorcery
sipsorcery approved these changes Sep 10, 2021
View reviewed changes
Copy link
Contributor

@sipsorcery sipsorcery left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Nice pickup of the duplicate project GUID.

Update: Will test it out this evening.

@sipsorcery
Copy link
Contributor

sipsorcery commented Sep 10, 2021

tACK 57b3c5b.

@fanquake fanquake merged commit 5c0f46c into bitcoin:master Sep 11, 2021
sidhujag pushed a commit to syscoin/syscoin that referenced this pull request Sep 11, 2021
@fanquake
Merge bitcoin#22908: build: Drop 32-bit build configurations for MSVC
1e63696
@hebasto hebasto deleted the 210907-win32 branch September 11, 2021 07:03
@bitcoin bitcoin locked and limited conversation to collaborators Oct 30, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer

@sipsorcery sipsorcery sipsorcery approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

Build system Windows

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@hebasto @practicalswift @laanwj @fanquake @sipsorcery