doc: provide context for CNetAddr::UnserializeV1Array() and span.h with lifetimebound #22881
Conversation
|
I just saw this explanatory comment at the time: https://github.com/bitcoin/bitcoin/pull/19387/files#r451060526. Not sure if the context is still the same, as the |
|
Yeah, this was done intentionally to keep span.h reusable without depending on other project files. I don't think anything changed about that. I don't personally feel strongly either way; just pointing out the reason back then. |
|
cr ACK 419d4767d07f0d9affddca6bb8c469ae79a47d63 |
|
cc @theuni |
|
(If it is preferred to keep span.h self-contained, I'd be tempted to convert this patch to documenting the intention and reason here and wrt #22140 to help future readers of the code.) |
|
No strong opinion here, remember that in principle the entire file can be considered temporary compatibility code until c++20, it's fine with me to treat it as a self-contained drop-in instead of really a part of our project. |
jonatack
changed the title
jonatack
force-pushed
the
span-lifetimebound
branch
from
419d476 to
33c6a20
Compare
|
Updated this patch to provide contextual documentation for developers regarding
|
|
Thanks for the clarifications. |
…Array() and span.h with lifetimebound 33c6a20 span, doc: provide span.h context and explain lifetimebound definition (Jon Atack) d14395b net, doc: provide context for UnserializeV1Array() (Jon Atack) Pull request description: Add contextual documentation for developers and future readers of the code regarding - CNetAddr::UnserializeV1Array (see bitcoin#22140) - Span and why it defines Clang lifetimebound locally rather than using the one in attributes.h ACKs for top commit: laanwj: Documentation review ACK 33c6a20 Tree-SHA512: cb8e6a6c23b36c9ef7499257e97c5378ec895bb9122b79b63b572d9721a1ae6ce6c0be7ad61bdf976c255527ae750fc9ff4b3e03c07c6c797d14dbc82ea9fb3a
6 participants
Add contextual documentation for developers and future readers of the code regarding