-
Notifications
You must be signed in to change notification settings - Fork 38.7k
doc: Added hyperlink for doc/build #22880
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
maflcko
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please squash your commits according to https://github.com/bitcoin/bitcoin/blob/master/CONTRIBUTING.md#squashing-commits
|
@MarcoFalke @laanwj Please check everything is ok? |
|
You will need to rebase on current master |
@MarcoFalke can you please guide me on how to do it properly I don't know how some errors occurred. |
|
You can use a search engine to find out how to rebase with git: https://duckduckgo.com/?q=how+to+use+git As the changes are small, I'd just reset the branch and start fresh: (Use at your own risk) Then recreate the commit. |
|
@MarcoFalke now you can check, look like everything is now finally ok😭 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ACK 53b3bb5e09b02e4257de9868c2b0c98c2b97e2b9
|
The commit message "Added repo-relative link" is a bit confusing to people who just browse the change history. In general, try to make it interpretable independent of context or PR discussion history. Changes ACK 53b3bb5e09b02e4257de9868c2b0c98c2b97e2b9 |
Well I mean you can change it quite easily |
|
@laanwj I feel it's ok now.🤞 |
|
@MarcoFalke @laanwj , |
Added hyperlink for the doc/build directory (https://github.com/bitcoin/bitcoin/tree/master/doc). This will be convenient for visitors to redirect.
