Skip to content

Conversation

@Pradumnasaraf
Copy link
Contributor

Added hyperlink for the doc/build directory (https://github.com/bitcoin/bitcoin/tree/master/doc). This will be convenient for visitors to redirect.
Screenshot (84)

@DrahtBot DrahtBot added the Docs label Sep 3, 2021
Copy link
Member

@maflcko maflcko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Pradumnasaraf
Copy link
Contributor Author

Pradumnasaraf commented Sep 9, 2021

@MarcoFalke @laanwj Please check everything is ok?

@maflcko
Copy link
Member

maflcko commented Sep 9, 2021

You will need to rebase on current master

@Pradumnasaraf
Copy link
Contributor Author

You will need to rebase on current master

@MarcoFalke can you please guide me on how to do it properly I don't know how some errors occurred.

@maflcko
Copy link
Member

maflcko commented Sep 9, 2021

You can use a search engine to find out how to rebase with git: https://duckduckgo.com/?q=how+to+use+git

As the changes are small, I'd just reset the branch and start fresh: (Use at your own risk)

git checkout add-hyper-install.md
git fetch origin a5d00d4baff27b4185ea086af571142af17c32e4
git reset --hard a5d00d4baff27b4185ea086af571142af17c32e4

Then recreate the commit.

@Pradumnasaraf
Copy link
Contributor Author

@MarcoFalke now you can check, look like everything is now finally ok😭

Copy link
Member

@maflcko maflcko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK 53b3bb5e09b02e4257de9868c2b0c98c2b97e2b9

@maflcko maflcko changed the title Added hyperlink for doc/build doc: Added hyperlink for doc/build Sep 9, 2021
@laanwj
Copy link
Member

laanwj commented Sep 9, 2021

The commit message "Added repo-relative link" is a bit confusing to people who just browse the change history. In general, try to make it interpretable independent of context or PR discussion history.

Changes ACK 53b3bb5e09b02e4257de9868c2b0c98c2b97e2b9

@Pradumnasaraf
Copy link
Contributor Author

Pradumnasaraf commented Sep 9, 2021

The commit message "Added repo-relative link" is a bit confusing to people who just browse the change history. In general, try to make it interpretable independent of context or PR discussion history.

Changes ACK 53b3bb5

@laanwj Noted. BTW when it will get merged?

@laanwj
Copy link
Member

laanwj commented Sep 9, 2021

@laanwj Noted. Do I need to change anything?

Well I mean you can change it quite easily git commit --amend, force-push. Change it, say, to the same as what the PR title now is.

@Pradumnasaraf
Copy link
Contributor Author

Pradumnasaraf commented Sep 9, 2021

@laanwj I feel it's ok now.🤞

@Pradumnasaraf
Copy link
Contributor Author

@MarcoFalke @laanwj ,
Look like all the checks have been passed, now we can merge?

@maflcko maflcko merged commit 384d076 into bitcoin:master Sep 10, 2021
sidhujag pushed a commit to syscoin/syscoin that referenced this pull request Sep 11, 2021
@bitcoin bitcoin locked and limited conversation to collaborators Oct 30, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants