Skip to content

ci: Re-enable verify-commits.py check #22744

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
fanquake merged 2 commits into from
Aug 31, 2021
Merged

ci: Re-enable verify-commits.py check #22744

fanquake merged 2 commits into from
Aug 31, 2021

Conversation

@maflcko
Copy link
Member

@maflcko maflcko commented Aug 19, 2021 •
edited
Loading

Might be useful to detect bugs in the script itself or an accidentally missed signature.

@fanquake fanquake added the Tests label Aug 19, 2021
@maflcko
Copy link
Member Author

maflcko commented Aug 19, 2021

To clarify: There is currently no Cirrus CI cron job running. Previously this was run on Travis every day with the last two days worth of commits. Now it runs on every push on the last 10 commits.

@DrahtBot DrahtBot mentioned this pull request Aug 20, 2021
Merged
@DrahtBot
Copy link
Contributor

DrahtBot commented Aug 20, 2021 •
edited
Loading

The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

Conflicts

No conflicts as of last run.

@maflcko maflcko force-pushed the 2108-ciVerifyCommits branch from fa8e58c to 555528c Compare August 20, 2021 09:15
josibake
josibake reviewed Aug 23, 2021
View reviewed changes
Copy link
Member

@josibake josibake left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Concept ACK

@Zero-1729
Copy link
Contributor

Zero-1729 commented Aug 23, 2021

Concept ACK

MarcoFalke added 2 commits August 26, 2021 11:17
@maflcko maflcko force-pushed the 2108-ciVerifyCommits branch from 555528c to fa00160 Compare August 26, 2021 10:04
@josibake
Copy link
Member

josibake commented Aug 27, 2021

ACK fa00160

not sure if there is a better way to test this, but I rebased the branch on master, git reset upstream/master, set the CIRRUS env variables and ran ./ci/lint/06_script.sh

verified everything worked as expected:

Success: no issues found in 213 source files
Skipping shell linting since shellcheck is not installed.
gpg: key 410108112E7EA81F: "Hennadii Stepanov (hebasto) <[email protected]>" not changed
gpg: key 944D35F9AC3DB76A: "Michael Ford (bitcoin-otc) <[email protected]>" not changed
gpg: key D300116E1C875A3D: "MeshCollider <[email protected]>" not changed
gpg: key 3648A882F4316B9B: "Marco Falke <[email protected]>" not changed
gpg: key 29D4BCB6416F53EC: "Jonas Schnelli <[email protected]>" not changed
gpg: key 860FEB804E669320: "Pieter Wuille <[email protected]>" not changed
gpg: key 74810B012346C9A6: "Wladimir J. van der Laan <[email protected]>" not changed
gpg: Total number processed: 7
gpg:              unchanged: 7
Using verify-commits data from /home/josibake/bitcoin/contrib/verify-commits
There is a valid path from "HEAD" to 84be9a89c1a49a7be5bc43d832b4cb9cbd09fce3 where all commits are signed!

@maflcko
Copy link
Member Author

maflcko commented Aug 27, 2021

not sure if there is a better way to test this

Easiest way would be to just merge it 😬

@josibake
Copy link
Member

josibake commented Aug 27, 2021

just merge it

🤠

Zero-1729
Zero-1729 reviewed Aug 27, 2021
View reviewed changes
Copy link
Contributor

@Zero-1729 Zero-1729 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tACK fa00160

Followed @josibake's steps and checked that everything still works as expected 🥤

fanquake
fanquake approved these changes Aug 31, 2021
View reviewed changes
Copy link
Member

@fanquake fanquake left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

untested ACK fa00160

@fanquake fanquake merged commit 19aa5af into bitcoin:master Aug 31, 2021
@maflcko maflcko deleted the 2108-ciVerifyCommits branch August 31, 2021 13:10
sidhujag pushed a commit to syscoin/syscoin that referenced this pull request Aug 31, 2021
@fanquake
Merge bitcoin#22744: ci: Re-enable verify-commits.py check
58c3ce0
@bitcoin bitcoin locked as resolved and limited conversation to collaborators Aug 31, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@fanquake fanquake fanquake approved these changes

+2 more reviewers

@Zero-1729 Zero-1729 Zero-1729 left review comments

@josibake josibake josibake approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

Tests

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@maflcko @DrahtBot @Zero-1729 @josibake @fanquake