Skip to content

MOVEONLY: tests: Move addrman ser/deser tests to addrman_tests.cpp #22725

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
fanquake merged 1 commit into from
Aug 18, 2021
Merged

MOVEONLY: tests: Move addrman ser/deser tests to addrman_tests.cpp #22725

fanquake merged 1 commit into from
Aug 18, 2021

Conversation

@jnewbery
Copy link
Contributor

@jnewbery jnewbery commented Aug 17, 2021

Addrman serialization/deserialization tests are currently in net_tests.cpp.
Move them to addrman_tests.cpp with the rest of the addrman tests.

Reviewer hint: review using git diff --color-moved=dimmed-zebra

@jnewbery
[MOVEONLY] [tests] Move addrman ser/deser tests to addrman_tests.cpp
aaa6ad5 
Addrman serialization/deserialization tests are currently in net_tests.cpp.
Move them to addrman_tests.cpp with the rest of the addrman tests.

Reviewer hint: review using `git diff --color-moved=dimmed-zebra`
@fanquake fanquake added the Tests label Aug 17, 2021
@Zero-1729
Copy link
Contributor

Zero-1729 commented Aug 17, 2021

Concept ACK

@maflcko
Copy link
Member

maflcko commented Aug 17, 2021

review ACK aaa6ad5 📺

Show signature and timestamp

Signature:

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA512

review ACK aaa6ad54554abd1666cb60285ed6f890698ca620 📺
-----BEGIN PGP SIGNATURE-----

iQGzBAEBCgAdFiEE+rVPoUahrI9sLGYTzit1aX5ppUgFAlwqrYAACgkQzit1aX5p
pUifbAv/ZAhkEB6Ya+XSusX1VfN4B1dq5FVt+tRDK3H416jrn4nJyCqsjRXO1KSW
MUtPyrmntYcqioDdWSNQL5n4+jBdbGZx0c4x8BR+EgGynpxz27BWa+eReqUwBQHM
ivIPMZYSreNcCmrBIUr0zRpbPE8hPXCk948klVACo8a0N/l3zKA5jUFJUb9eleZ/
iKPx3o8ILqmWUw7K+5SnSk0HwF0+uwZUqFU8Q0iTvT6BtpMYUB/86koxF2BguPbS
ep66iyjubO8jyIds9HDhap8Qur/5AqMae8zq8zfa69pr6oOMG8lS8/EKAa4SeDvM
/61d3aQwvzc2hT9pVtXvY9owko87GsinShzJCG57OItnI4KAsTpZ0XG4bbEtbhnz
Qc3+zSnI5WRLHH0rY5kUXu97VkxYVIbx7TTL76mZ4iy6JT4HR9bHTCdqIRC2Wzpk
rPPzrFf70KlsgQxeCNeqynissO8LeTYUdV2kgBrLlyg5DH07uPDVlAnYqJxRQfzu
MENYe31n
=jPb5
-----END PGP SIGNATURE-----

Timestamp of file with hash f5716a51de0be4a4dcc3523d09a9e5d8d30225a82156c3d1161a4d25fd7c53e7 -

@mjdietzx
Copy link
Contributor

mjdietzx commented Aug 17, 2021

ACK aaa6ad5

@Saviour1001
Copy link

Saviour1001 commented Aug 17, 2021

Concept ACK aaa6ad5

@DrahtBot
Copy link
Contributor

DrahtBot commented Aug 17, 2021

The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

Conflicts

Reviewers, this pull request conflicts with the following ones:

  • #22697 (addrman: Remove CAddrMan::Clear() function by jnewbery)
  • #20196 (net: fix GetListenPort() to derive the proper port by vasild)

If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.

@DrahtBot DrahtBot mentioned this pull request Aug 17, 2021
Merged
@fanquake fanquake merged commit b5c468c into bitcoin:master Aug 18, 2021
@DrahtBot DrahtBot mentioned this pull request Aug 18, 2021
Merged
@jnewbery jnewbery deleted the 2021-08-move-addrman-tests branch August 18, 2021 06:37
sidhujag pushed a commit to syscoin/syscoin that referenced this pull request Aug 20, 2021
@fanquake
Merge bitcoin#22725: MOVEONLY: tests: Move addrman ser/deser tests to…
93a8afb 
… addrma…
@bitcoin bitcoin locked as resolved and limited conversation to collaborators Aug 18, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

No reviews

Assignees

No one assigned

Labels

Tests

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@jnewbery @Zero-1729 @maflcko @mjdietzx @Saviour1001 @DrahtBot @fanquake