Fix getbalance discrepency #2272
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Two changes: Use IsConfirmed() instead of IsFinal(), so 'getbalance "*" 0' uses the same 'is this output spendable' criteria as 'getbalance'. Fixes issue bitcoin#172. And a tiny refactor to CWallet::GetBalance() (redundant call to IsFinal -- IsConfirmed calls IsFinal). getbalance with no arguments and 'getbalance "*" 0' could return different different results,
|
Does this affect Bitcoin-Qt in a way we need to take care of? Just asking without any research... |
|
Automatic sanity-testing: PASSED, see http://jenkins.bluematt.me/pull-tester/d28bd8b7ca2d0d9ad5f01e005b49acdd3a9eb917 for binaries and test log. |
Member
|
ACK |
|
@sipa Can you comment to my question above ;)? |
gavinandresen
added a commit
that referenced
this pull request
Apr 8, 2013
Fix getbalance discrepency
Member
|
I don't think this influences the GUi in any way. |
namecoin-qt
referenced
this pull request
in namecoin-qt/namecoin-qt
Jun 10, 2013
… plus special handling of OP_NAME_NEW.
davispuh
referenced
this pull request
in davispuh/namecoin
Feb 18, 2014
… plus special handling of OP_NAME_NEW.
laudney
pushed a commit
to reddcoin-project/reddcoin-3.10
that referenced
this pull request
Mar 19, 2014
Fix getbalance discrepency
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Two changes:
Use IsConfirmed() instead of IsFinal(), so 'getbalance "*" 0' uses the same
'is this output spendable' criteria as 'getbalance'. Fixes issue #172.
And a tiny refactor to CWallet::GetBalance() (redundant call to IsFinal -- IsConfirmed
calls IsFinal).