build: enable SC2046 and SC2086 in lint-shell #22695
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
If you want to enable these you actually need to fix all of the warnings / issues in the code. You will see them all in the lint CI output. Or you can run the linter locally. |
Contributor
Author
|
Ran the linter locally, and can see the following count of cases: $ test/lint/lint-shell.sh | grep SC2046 | wc -l
18
$ test/lint/lint-shell.sh | grep SC2086 | wc -l
178Thanks @fanquake for the clarification, I'll fix all cases and push. |
Member
|
Concept ACK |
Member
|
Concept ACK, these seem quite serious. |
Member
|
This might accidentally fix #12528 |
Member
Contributor
Author
|
Sorry, lost track of this PR. @hebasto thanks for opening a replacement! Closing this now in favour of yours. |
laanwj
added a commit
that referenced
this pull request
Nov 15, 2021
fe0ff56 test: Enable SC2046 shellcheck rule (Hennadii Stepanov) 9a1ad7b test: Enable SC2086 shellcheck rule (Hennadii Stepanov) Pull request description: Closes #20879. Replaces #22695. **Note for reviewers**. Some touched shell scripts are not being run in CI, therefore they require more thorough reviewing: - `contrib/devtools/gen-manpages.sh` - `contrib/macdeploy/detached-sig-apply.sh` - `contrib/windeploy/detached-sig-create.sh` - `src/qt/res/animation/makespinner.sh` ACKs for top commit: laanwj: Code review re-ACK fe0ff56 Tree-SHA512: 73619b9a7bcb6cf0dfc4189a753ef550d40c82a3432bb9d8d8a994310d42594576038daac7e0c2fc004d716976bb1413b9a77848ecf088b25b69ed0773b77e8e
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As per #20879, this PR enables the
shellcheckrules SC2046 and SC2086 respectfully in the lint-shell.sh script to, amongst other things, prevent unintentional word-splitting, and make the shell scripts "conformant and therefore more robust", as dongcarl stated here.Closes #20879