Skip to content

Conversation

@slowy07
Copy link

@slowy07 slowy07 commented Aug 8, 2021

description fixing

fixing typo grammar spelling and replace to correct with reference from merriam webster and wikitionary

fixing example

messagebox.setInformativeText(QObject::tr("A fatal error occured. Check that settings file is writable, or try running with -nosettings."));

to

messagebox.setInformativeText(QObject::tr("A fatal error occurred. Check that settings file is writable, or try running with -nosettings."));

testing

unitest not include because just fixing typo with correct one

@hebasto
Copy link
Member

hebasto commented Aug 8, 2021

Changes in subtrees (crc32c, leveldb, secp256k1) should be submitted to upstreams.

Copy link
Contributor

@Zero-1729 Zero-1729 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Concept ACK (for the non upstream changes, depends & qt)

@DrahtBot
Copy link
Contributor

DrahtBot commented Aug 8, 2021

The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

Conflicts

Reviewers, this pull request conflicts with the following ones:

  • #22653 (refactor: Rename JoinErrors and re-use it by hebasto)

If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.

@DrahtBot
Copy link
Contributor

🐙 This pull request conflicts with the target branch and needs rebase.

Want to unsubscribe from rebase notifications on this pull request? Just convert this pull request to a "draft".

}

// Proccess the data in predetermined block sizes with tables for quickly
// Procces the data in predetermined block sizes with tables for quickly
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Process

@fanquake fanquake closed this Aug 11, 2021
@bitcoin bitcoin locked as resolved and limited conversation to collaborators Aug 18, 2022
@slowy07 slowy07 deleted the docs-fixing branch June 19, 2023 17:57
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants