refactor: Rename JoinErrors and re-use it #22653
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
-BEGIN VERIFY SCRIPT- sed -i -e 's/JoinErrors/MakeUnorderedList/' -- src/qt/bitcoin.cpp -END VERIFY SCRIPT-
Member
Author
Contributor
|
Concept ACK |
Contributor
|
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers. ConflictsReviewers, this pull request conflicts with the following ones: If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first. |
Zero-1729
reviewed
Aug 7, 2021
This was referenced Aug 7, 2021
Merged
Talkless
approved these changes
Aug 10, 2021
ryanofsky
approved these changes
Aug 10, 2021
| "\nVerifies blockchain database.\n", | ||
| { | ||
| {"checklevel", RPCArg::Type::NUM, RPCArg::DefaultHint{strprintf("%d, range=0-4", DEFAULT_CHECKLEVEL)}, | ||
| strprintf("How thorough the block verification is:\n - %s", Join(CHECKLEVEL_DOC, "\n- "))}, |
Contributor
There was a problem hiding this comment.
In commit "refactor: Reuse MakeUnorderedList where possible" (bb56486)
This looks good but just want to note small change in behavior here: space is removed before the first "-"
Member
Author
There was a problem hiding this comment.
Yes. While working on this PR I was wondering what is the purpose of a space before the first "-" :)
It seems ignored:
$ src/bitcoin-cli --version
Bitcoin Core RPC client version v22.99.0-bb56486a170a
$ src/bitcoin-cli help verifychain > ~/pr
$ src/bitcoin-cli --version
Bitcoin Core RPC client version v22.99.0-03826aecc56c
$ src/bitcoin-cli help verifychain > ~/master
$ diff ~/master ~/pr # empty
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A nice
JoinErrorsutility function was introduced in bitcoin-core/gui#379 by Russell Yanofsky.This PR renames this function and re-uses it across the code base.