-
Notifications
You must be signed in to change notification settings - Fork 38.6k
guix-verify: Non-zero exit code when anything fails #22643
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
fanquake
merged 1 commit into
bitcoin:master
from
dongcarl:2021-08-guix-verify-exit-code
Aug 9, 2021
Merged
guix-verify: Non-zero exit code when anything fails #22643
fanquake
merged 1 commit into
bitcoin:master
from
dongcarl:2021-08-guix-verify-exit-code
Aug 9, 2021
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
dongcarl
commented
Aug 5, 2021
Previously, if verification fails, the correct message will be printed, but the exit code would still be 0.
Member
|
ACK d451b60 |
hebasto
pushed a commit
to hebasto/bitcoin
that referenced
this pull request
Aug 9, 2021
Previously, if verification fails, the correct message will be printed, but the exit code would still be 0. Github-Pull: bitcoin#22643 Rebased-From: d451b60
Merged
Member
|
Backported in #22629. |
hebasto
pushed a commit
to hebasto/bitcoin
that referenced
this pull request
Aug 9, 2021
Previously, if verification fails, the correct message will be printed, but the exit code would still be 0. Github-Pull: bitcoin#22643 Rebased-From: d451b60
sidhujag
pushed a commit
to syscoin/syscoin
that referenced
this pull request
Aug 10, 2021
d451b60 guix-verify: Non-zero exit code when anything fails (Carl Dong) Pull request description: ``` Previously, if verification fails, the correct message will be printed, but the exit code would still be 0. ``` ACKs for top commit: achow101: ACK d451b60 Tree-SHA512: 695d72121f308d8a66db780eca16878fb378b4d766de5b58c2d6f778c5661a2f7bdf37a96e8e8e283b0a46b5d55f24bca05fa7509aa1822f0854c50064200572
hebasto
pushed a commit
to hebasto/bitcoin
that referenced
this pull request
Aug 20, 2021
Previously, if verification fails, the correct message will be printed, but the exit code would still be 0. Github-Pull: bitcoin#22643 Rebased-From: d451b60
hebasto
pushed a commit
to hebasto/bitcoin
that referenced
this pull request
Aug 20, 2021
Previously, if verification fails, the correct message will be printed, but the exit code would still be 0. Github-Pull: bitcoin#22643 Rebased-From: d451b60
hebasto
pushed a commit
to hebasto/bitcoin
that referenced
this pull request
Aug 20, 2021
Previously, if verification fails, the correct message will be printed, but the exit code would still be 0. Github-Pull: bitcoin#22643 Rebased-From: d451b60
laanwj
added a commit
that referenced
this pull request
Aug 26, 2021
32e1424 Fix build with Boost 1.77.0 (Rafael Sadowski) cb34a0a qt: Handle new added plurals in bitcoin_en.ts (Hennadii Stepanov) 068985c doc: Mention the flat directory structure for uploads (Andrew Chow) 27d43e5 guix: Don't include directory name in SHA256SUMS (Andrew Chow) 88fb7e3 test: fix bug in 22686 (S3RK) 63fec7e clientversion: No suffix #if CLIENT_VERSION_IS_RELEASE (Carl Dong) dfaffbe test: Test for ApproximateBestSubset edge case with too little fees (Andrew Chow) e86b023 wallet: Assert that enough was selected to cover the fees (Andrew Chow) ffc81e2 wallet: Use GetSelectionAmount for target value calculations (Andrew Chow) ce77b45 release: Release with separate SHA256SUMS and sig files (Carl Dong) cb491bd guix-verify: Non-zero exit code when anything fails (Carl Dong) 6a611d2 gui: ensure external signer option remains disabled without signers (Andrew Chow) e9b4487 qt: Fix regression in "Encrypt Wallet" menu item (Hennadii Stepanov) 57fce06 consensus/params: simplify ValidDeployment check to avoid gcc warning (Anthony Towns) e9d30fb ci: Run fuzzer task for the master branch only (Hennadii Stepanov) Pull request description: Backported: 1) #22730 1) bitcoin-core/gui#393 1) #22597 1) bitcoin-core/gui#396 1) #22643 1) #22642 1) #22685 1) #22686 1) #22654 1) #22742 1) bitcoin-core/gui#406 1) #22713 ACKs for top commit: laanwj: Code list-of-backported-PRs review ACK 32e1424 Tree-SHA512: f5e2dd1be6cdcd39368eeb5d297b3ff4418d0bf2e70c90e59ab4ba1dbf16f773045d877b4997511de58c3aca75a978dcf043e338bad23951557e2a27ccc845f6
fujicoin
pushed a commit
to fujicoin/fujicoin-22.0
that referenced
this pull request
Aug 27, 2021
Previously, if verification fails, the correct message will be printed, but the exit code would still be 0. Github-Pull: bitcoin/bitcoin#22643 Rebased-From: d451b60d22576dff7a2c8d6a8b5880d9d69e397c
gwillen
pushed a commit
to gwillen/elements
that referenced
this pull request
Jul 27, 2022
Previously, if verification fails, the correct message will be printed, but the exit code would still be 0. Github-Pull: bitcoin/bitcoin#22643 Rebased-From: d451b60
gwillen
pushed a commit
to gwillen/elements
that referenced
this pull request
Aug 1, 2022
Previously, if verification fails, the correct message will be printed, but the exit code would still be 0. Github-Pull: bitcoin/bitcoin#22643 Rebased-From: d451b60
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.