test: Set regtest.BIP66Height = 102 to speed up tests #22632
Conversation
maflcko
force-pushed
the
2108-regtestFasterBip66
branch
from
295236b to
fafe896
Compare
|
Strong Concept ACK |
|
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers. ConflictsReviewers, this pull request conflicts with the following ones:
If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first. |
|
Concept + code review ACK fafe896 |
|
Concept ACK |
There was a problem hiding this comment.
ACK fafe896. Full functional test suite showed few second speed incrase on my laptop (although I didn't do proper benchmarking with multiple runs, just single time ./test/functional/test_runner.py on current master vs this PR).
|
This should only affect the speed of |
theStack
left a comment
theStack
left a comment
There was a problem hiding this comment.
Tested ACK fafe896
master branch:
$ time ./test/functional/feature_dersig.py
...
0m15.29s real 0m11.55s user 0m05.72s system
PR branch:
$ time ./test/functional/feature_dersig.py
...
0m03.97s real 0m01.42s user 0m01.34s system
🎉
Zero-1729
left a comment
Zero-1729
left a comment
There was a problem hiding this comment.
tACK fafe896
Tested on macOS v11.4
Master
$ time ./test/functional/feature_dersig.py
...
./test/functional/feature_dersig.py 1.65s user 0.42s systemAfter Patch
$ time ./test/functional/feature_dersig.py
...
./test/functional/feature_dersig.py 0.37s user 0.15s system
|
crACK fafe896 |
hg333
left a comment
hg333
left a comment
There was a problem hiding this comment.
tACK fafe896
Tested on Ubuntu 20.04
Master branch:
$ time ./test/functional/feature_dersig.py
...
real 0m23.470s
user 0m6.761s
sys 0m1.232s
PR branch:
$ time ./test/functional/feature_dersig.py
...
real 0m3.051s
user 0m0.646s
sys 0m0.131s
|
ACK fafe896 |
…tests fafe896 test: Set regtest.BIP66Height = 102 to speed up tests (MarcoFalke) Pull request description: No need to waste time by forcing creation of more than 1000 blocks to get the benefits of being able to test BIP 66. Also, reducing the height makes it more likely that (third-party) tests are conforming to BIP 66, which is enforced on mainnet for all new blocks. ACKs for top commit: GeneFerneau: Concept + code review ACK [fafe896](bitcoin@fafe896) 0xB10C: crACK fafe896 laanwj: ACK fafe896 Zero-1729: tACK fafe896 kristapsk: ACK fafe896. Full functional test suite showed few second speed incrase on my laptop (although I didn't do proper benchmarking with multiple runs, just single `time ./test/functional/test_runner.py` on current master vs this PR). theStack: Tested ACK fafe896 hg333: tACK bitcoin@fafe896 Tree-SHA512: 4bbee3c8587d612e74a59fde49b6439c1296f2fc27d3a7cf59a35e920f729fdd581c930290bd04def618f81412236676ddb99b4ceb4d80dfb9fd610b128a04b1
11 participants
No need to waste time by forcing creation of more than 1000 blocks to get the benefits of being able to test BIP 66. Also, reducing the height makes it more likely that (third-party) tests are conforming to BIP 66, which is enforced on mainnet for all new blocks.