[p2p] Small follow-ups to 21528 #22618
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amitiuttarwar
changed the title
Member
|
Missing #21528 (comment) ? 😅 |
amitiuttarwar
force-pushed
the
2021-08-blackhole-followup
branch
from
1396662 to
7ac9c1f
Compare
Contributor
Author
|
@MarcoFalke fixed 😛 |
jonatack
reviewed
Aug 3, 2021
Member
jonatack
left a comment
jonatack
left a comment
There was a problem hiding this comment.
ACK 7ac9c1f22b15509ad1775ecd707ea8615c05d306
Feel free to ignore the optional ideas below.
jonatack
reviewed
Aug 3, 2021
Contributor
|
ACK 7ac9c1f, esp. with @jonatack's suggestions above (e.g. spelling and release notes). |
Member
|
cr ACK 7ac9c1f22b15509ad1775ecd707ea8615c05d306 |
jnewbery
reviewed
Aug 4, 2021
Contributor
jnewbery
left a comment
jnewbery
left a comment
There was a problem hiding this comment.
ACK 7ac9c1f22b15509ad1775ecd707ea8615c05d306
And fix a typo in the test.
Currently, this call to SetupAddressRelay will never return false because of the previous guard that returns early if the peer is not an inbound connection. Rather than implicitly relying on this guarantee, throw an error in the debug build if it ever changes.
amitiuttarwar
force-pushed
the
2021-08-blackhole-followup
branch
from
7ac9c1f to
9778b0f
Compare
Contributor
Author
|
thanks for reviews! updated to incorporate feedback |
Contributor
|
re-ACK 9778b0f |
Member
|
ACK 9778b0f |
sidhujag
pushed a commit
to syscoin/syscoin
that referenced
this pull request
Aug 5, 2021
Fabcien
pushed a commit
to Bitcoin-ABC/bitcoin-abc
that referenced
this pull request
Feb 1, 2022
Summary: Backport of [[bitcoin/bitcoin#22618 | core#22618]]. Depends on D10933. Ref T1693. Test Plan: ninja all check-all Reviewers: #bitcoin_abc, tyler-smith, PiRK Reviewed By: #bitcoin_abc, tyler-smith, PiRK Subscribers: tyler-smith Maniphest Tasks: T1693 Differential Revision: https://reviews.bitcoinabc.org/D10934
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a release note & addresses this review comment to make expectations more explicit.