doc: Add release notes for 22570 (ignore banlist.dat) #22603
Conversation
doc/release-notes.md
Outdated
There was a problem hiding this comment.
(if I'm understanding your intention here)
| `banlist.dat` is ignored. Bitcoin Core version 22.x is the only version that | |
| `banlist.dat` is ignored. Bitcoin Core version 22.x is the last version that |
There was a problem hiding this comment.
it's the last version that can read .dat and the only version that can read .dat and write to .json, so you're both right :-) Maybe just split it into two separate clauses?
vasild
left a comment
vasild
left a comment
There was a problem hiding this comment.
ACK fae540b70ae41db08a5999c621fdd896dca8d423
|
Does this need some more generic notice for upgrades from older versions? I.e. if you upgrade from .21 or earlier directly to 23.x, you will lose your banlist data, unless you upgrade to 22.x first and let it convert it, right? |
As I understand it you won't actually lose the data, it will just become inaccessible, but the |
|
yes, but by the time they notice, a new json might already have been created with some new entries, and then you'd have to merge it somehow (or lose the new entries). Not a huge deal I guess, but it couldn't hurt to spell out that scenario in the release notes. At least then you'll have something to point to if someone opens a bug report about how their banlist is gone :-). |
maflcko
force-pushed
the
2108-docBanlistDatIgnore
branch
from
fae540b to
fa7a93a
Compare
|
Pushed a more verbose version |
vasild
left a comment
vasild
left a comment
There was a problem hiding this comment.
ACK fa7a93ada2df8d88c9cd411b441110ae6ddec2c0
maflcko
force-pushed
the
2108-docBanlistDatIgnore
branch
from
fa7a93a to
fa2c868
Compare
|
ACK fa2c868 |
| ----- | ||
|
|
||
| * On startup, the list of banned hosts and networks (via `setban` RPC) in | ||
| `banlist.dat` is ignored and only `banlist.json` is considered. Bitcoin Core |
There was a problem hiding this comment.
suggestions:
- "(via the
setbanRPC or the GUI peers tab)" - "is now ignored and
banlist.jsonis read instead.` - s/double check/verify/
- s/22.x is/22.x was/ (if this is for the v23.0 release notes)
There was a problem hiding this comment.
might do if I have to retouch. Otherwise this can be edited in the wiki in about 6 months
….dat) fa2c868 doc: Add release notes for 22570 (ignore banlist.dat) (MarcoFalke) Pull request description: Follow-up to bitcoin#22570 ACKs for top commit: tryphe: ACK fa2c868 vasild: ACK fa2c868 Zero-1729: ACK fa2c868 Tree-SHA512: 58eef340b6211bcdecf3826ac145afd476c397f110daa6783521c0c1e1be1ffbd2d24ad20c77921abbe5cdb8e644d3cd64e14e2819746cf0e5123fb7cc445d63
8 participants
Follow-up to #22570