Skip to content

Do not call ResendWalletTransactions when reindexing or importing #2259

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
gavinandresen merged 1 commit into from
Feb 6, 2013
Merged

Do not call ResendWalletTransactions when reindexing or importing #2259

gavinandresen merged 1 commit into from
Feb 6, 2013
+6 −1

Conversation

@rdponticelli
Copy link
Contributor

@rdponticelli rdponticelli commented Feb 1, 2013

Calling ResendWalletTransactions when reindexing or importing spams
other nodes with our old transactions, because they become unconfirmed.

@sipa
Copy link
Member

sipa commented Feb 1, 2013

ACK

@BitcoinPullTester
Copy link

BitcoinPullTester commented Feb 5, 2013

Automatic sanity-testing: PASSED, see http://jenkins.bluematt.me/pull-tester/55a05fb8d268d9faa5aca48f7d1a10f2afd636da for binaries and test log.

@gavinandresen
Copy link
Contributor

gavinandresen commented Feb 5, 2013

ACK. There will be a lot of reindexing with 0.8, so I'm inclined to pull this sooner.

@gmaxwell
Copy link
Contributor

gmaxwell commented Feb 5, 2013

Agreed on the 0.8 reindexing— However, I suggest this also be guarded by IsInitialBlockDownload (I actually thought we were already doing that) so that we minimize spamming the content of an old wallet while syncing up a node from the network (a very common 0.8 install pattern, I expect).

@rdponticelli
Do not call ResendWalletTransactions when reindexing, importing or on…
e90b831 
… IBD

Calling ResendWalletTransactions when reindexing, importing or on IBD spams
other nodes with our old transactions, because they become unconfirmed.
@rdponticelli
Copy link
Contributor Author

rdponticelli commented Feb 5, 2013

Added @gmaxwell suggestion, and a comment on the source.

@sipa
Copy link
Member

sipa commented Feb 6, 2013

ACK; before 0.8

@Diapolo
Copy link

Diapolo commented Feb 6, 2013

Is that logical && correct?

@gavinandresen
Copy link
Contributor

gavinandresen commented Feb 6, 2013

Yes, it is logical and correct. Pulling.

gavinandresen added a commit that referenced this pull request Feb 6, 2013
@gavinandresen
Merge pull request #2259 from Criptomonedas/dontresend
43ba1a1 
Do not call ResendWalletTransactions when reindexing or importing
@gavinandresen gavinandresen merged commit 43ba1a1 into bitcoin:master Feb 6, 2013
@rdponticelli rdponticelli deleted the dontresend branch February 6, 2013 21:25
@rdponticelli rdponticelli mentioned this pull request May 12, 2013
Closed
laudney pushed a commit to reddcoin-project/reddcoin-3.10 that referenced this pull request Mar 19, 2014
@gavinandresen
Merge pull request bitcoin#2259 from Criptomonedas/dontresend
431ba2f 
Do not call ResendWalletTransactions when reindexing or importing
@bitcoin bitcoin locked as resolved and limited conversation to collaborators Sep 8, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

0.8.0

Development

Successfully merging this pull request may close these issues.

6 participants

@rdponticelli @sipa @BitcoinPullTester @gavinandresen @gmaxwell @Diapolo