Skip to content

Conversation

@jonatack
Copy link
Member

This patch adds additional addr-fetch peer connection state and timeout coverage as a follow-up to #22096.

@DrahtBot DrahtBot added the Tests label Jul 28, 2021
Copy link
Contributor

@ShubhamPalriwala ShubhamPalriwala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tAck f8d8eb5 and 9321086

Anything that increases Test Coverage is a yayy!

Tested on Ubuntu 21.04

Copy link
Contributor

@mzumsande mzumsande left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code review ACK f8d8eb5

@fanquake fanquake requested a review from amitiuttarwar August 16, 2021 03:04
@Saviour1001
Copy link

Tested ACK f8d8eb5

@maflcko maflcko merged commit 999f8b2 into bitcoin:master Aug 19, 2021
@jonatack jonatack deleted the p2p_addrfetch_test_enhancements branch August 19, 2021 20:06
sidhujag pushed a commit to syscoin/syscoin that referenced this pull request Aug 20, 2021
Fabcien added a commit to Bitcoin-ABC/bitcoin-abc that referenced this pull request Jan 28, 2022
Summary:
```
This patch adds additional addr-fetch peer connection state and timeout coverage as a follow-up to #22096.
```

Backport of [[bitcoin/bitcoin#22568 | core#22568]].

Ref T1696.

Test Plan:
  ./test/functional/test_runner.py p2p_addrfetch

Reviewers: #bitcoin_abc, PiRK

Reviewed By: #bitcoin_abc, PiRK

Maniphest Tasks: T1696

Differential Revision: https://reviews.bitcoinabc.org/D10926
@bitcoin bitcoin locked as resolved and limited conversation to collaborators Aug 19, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants