Skip to content

Conversation

@maflcko
Copy link
Member

@maflcko maflcko commented Jul 15, 2021

Without a size limit on the input data, the runtime is unbounded. Fix this by picking an upper bound on the maximum number of fuzz operations.

Reproducer from OSS-Fuzz (without bug report):
clusterfuzz-testcase-rolling_bloom_filter-5980807721254912.log

@maflcko maflcko changed the title fuzz: Speed up rolling_bloom_filter fuzz test fuzz: Limit max ops in rolling_bloom_filter fuzz target Jul 15, 2021
@DrahtBot DrahtBot added the Tests label Jul 15, 2021
Copy link
Contributor

@theStack theStack left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Concept and code review ACK faa86b7

@practicalswift
Copy link
Contributor

cr ACK faa86b7

@maflcko maflcko merged commit 2aa937e into bitcoin:master Jul 25, 2021
@maflcko maflcko deleted the 2107-fuzzRoll branch July 25, 2021 10:42
sidhujag pushed a commit to syscoin/syscoin that referenced this pull request Jul 28, 2021
… target

faa86b7 fuzz: Use ConsumeUInt256 helper to simplify rolling_bloom_filter fuzz test (MarcoFalke)
aaaa61f fuzz: Speed up rolling_bloom_filter fuzz test (MarcoFalke)

Pull request description:

  Without a size limit on the input data, the runtime is unbounded. Fix this by picking an upper bound on the maximum number of fuzz operations.

  Reproducer from OSS-Fuzz (without bug report):
  [clusterfuzz-testcase-rolling_bloom_filter-5980807721254912.log](https://github.com/bitcoin/bitcoin/files/6822159/clusterfuzz-testcase-rolling_bloom_filter-5980807721254912.log)

ACKs for top commit:
  practicalswift:
    cr ACK faa86b7
  theStack:
    Concept and code review ACK faa86b7

Tree-SHA512: eace588509dfddb2ba97baf86379fa713fa6eb758184abff676cb95807ff8ff36905eeaddeba05665b8464c35c57e2138f88caec71cbfb255e546bbe76558da0
@bitcoin bitcoin locked as resolved and limited conversation to collaborators Aug 18, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants