Skip to content

Fix syntax for getindexinfo params in help examples #22430

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
ghost wants to merge 1 commit into from
Closed

Fix syntax for getindexinfo params in help examples #22430

ghost wants to merge 1 commit into from

Conversation

@ghost
Copy link

@ghost ghost commented Jul 11, 2021 •
edited by ghost
Loading

txindex without quotes:

$ curl --user myusername --data-binary '{"jsonrpc": "1.0", "id": "curltest", "method": "getindexinfo", "params": [txindex]}' -H 'content-type: text/plain;' http://127.0.0.1:18333/



{"result":null,"error":{"code":-32700,"message":"Parse error"},"id":null}

txindex with quotes:

$ curl --user myusername --data-binary '{"jsonrpc": "1.0", "id": "curltest", "method": "getindexinfo", "params": ["txindex"]}' -H 'content-type: text/plain;' http://127.0.0.1:18333/



{"result":{"txindex":{"synced":true,"best_block_height":2032943}},"error":null,"id":"curltest"}

klementtan
klementtan approved these changes Jul 12, 2021
View reviewed changes
Copy link
Contributor

@klementtan klementtan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK e0aa8de

tested:

$ ./src/bitcoin-cli -signet help getindexinfo
...
Examples:
> bitcoin-cli getindexinfo
> curl --user myusername --data-binary '{"jsonrpc": "1.0", "id": "curltest", "method": "getindexinfo", "params": []}' -H 'content-type: text/plain;' http://127.0.0.1:8332/
> bitcoin-cli getindexinfo txindex
> curl --user myusername --data-binary '{"jsonrpc": "1.0", "id": "curltest", "method": "getindexinfo", "params": ["txindex"]}' -H 'content-type: text/plain;' http://127.0.0.1:8332/

@ghost ghost closed this Jul 12, 2021
@ghost ghost mentioned this pull request Aug 25, 2021
Merged
@bitcoin bitcoin locked as resolved and limited conversation to collaborators Aug 16, 2022
This pull request was closed.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

No reviews

Assignees

No one assigned

Labels

RPC/REST/ZMQ

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@klementtan @DrahtBot