-
Notifications
You must be signed in to change notification settings - Fork 38.8k
doc: Highlight DNS requests part in tor.md #22317
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers. ConflictsNo conflicts as of last run. |
|
ACK 9bcea02c5b5fb3d8c622a4a0dce20a4ab8961d99 |
kristapsk
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ACK 9bcea02c5b5fb3d8c622a4a0dce20a4ab8961d99
|
Thanks for updating. ACK 86a4a15 |
RiccardoMasutti
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ACK 86a4a15
|
ACK 86a4a15 |
lsilva01
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ACK 86a4a15
kristapsk
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ACK 86a4a15
theStack
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ACK 86a4a15
Agree that this privacy-relevant part deserves to be highlighted 🕵️
|
We're all on the same team. If you decide not to reopen as discussed on IRC, I can pickup. |
|
Reopened after reading this question: https://bitcoin.stackexchange.com/questions/111801/restrict-bitcoin-core-to-tor/ Change still makes sense, respect reviewers for their time to review and agree, hopeful this could get merged and improve docs. |
|
I think this isn't a bad (nor a good) idea. Because the Don't Repeat Yourself principle, |
|
I never realized this is mentioned somewhere in docs until I read it in one of the comments in some pull request. DNS is obviously important if discussing privacy so which doc would work better for users: 1 or 2? I have also tried other things to highlight this but they were not acceptable to other reviewers: #22317 (comment) |
for many users who would value better that doc be |
Thanks for sharing your opinion. I disagree though and this doc can be improved a lot. This is one of the improvements which had some ACKs. |
|
ACK 86a4a15 |
86a4a15 Highlight DNS request part (Prayank) Pull request description: _What?_ Highlight DNS requests part in Proxy section _Why?_ 1. DNS requests are very important while considering privacy 2. Lot of users might skip reading it because of the way it is mixed with everything else in the doc right now 3. I have seen lot of users ignoring DNS requests or unaware of such things while using privacy tools _How?_ Initially I had tried keeping these lines separate from code block but [Jonatack didn't agree with the changes](bitcoin#21157 (comment)). Harding suggested using [bold/italic in `<pre></pre>`](bitcoin#21157 (comment)). I have used the suggestions from previous PR and added `---` This is a part of alternative described in bitcoin#22316 ACKs for top commit: jonatack: ACK 86a4a15 Rspigler: ACK 86a4a15 achow101: ACK 86a4a15 RiccardoMasutti: ACK 86a4a15 lsilva01: ACK bitcoin@86a4a15 kristapsk: ACK 86a4a15 theStack: ACK 86a4a15 Tree-SHA512: a4fe0e8c08df330e5ca78ce19ce74be7034c653f4374469d928908847a6debf385283e3a6da66de600566c7bab6290ccd35df26864aef94cbb3f294123391437

What?
Highlight DNS requests part in Proxy section
Why?
How?
Initially I had tried keeping these lines separate from code block but Jonatack didn't agree with the changes. Harding suggested using bold/italic in
<pre></pre>. I have used the suggestions from previous PR and added---This is a part of alternative described in #22316