Skip to content

Conversation

@ghost
Copy link

@ghost ghost commented Jun 23, 2021

What?

Highlight DNS requests part in Proxy section

Why?

  1. DNS requests are very important while considering privacy
  2. Lot of users might skip reading it because of the way it is mixed with everything else in the doc right now
  3. I have seen lot of users ignoring DNS requests or unaware of such things while using privacy tools

How?

Initially I had tried keeping these lines separate from code block but Jonatack didn't agree with the changes. Harding suggested using bold/italic in <pre></pre>. I have used the suggestions from previous PR and added ---

This is a part of alternative described in #22316

@DrahtBot
Copy link
Contributor

DrahtBot commented Jun 23, 2021

The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

Conflicts

No conflicts as of last run.

@Rspigler
Copy link
Contributor

ACK 9bcea02c5b5fb3d8c622a4a0dce20a4ab8961d99

@DrahtBot DrahtBot mentioned this pull request Jun 23, 2021
Copy link
Contributor

@kristapsk kristapsk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK 9bcea02c5b5fb3d8c622a4a0dce20a4ab8961d99

@jonatack
Copy link
Member

Thanks for updating.

ACK 86a4a15

Copy link
Contributor

@RiccardoMasutti RiccardoMasutti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK 86a4a15

@Rspigler
Copy link
Contributor

ACK 86a4a15

Copy link
Contributor

@lsilva01 lsilva01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK 86a4a15

Copy link
Contributor

@kristapsk kristapsk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK 86a4a15

Copy link
Contributor

@theStack theStack left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK 86a4a15

Agree that this privacy-relevant part deserves to be highlighted 🕵️

@ghost ghost closed this Jul 12, 2021
@Rspigler
Copy link
Contributor

We're all on the same team. If you decide not to reopen as discussed on IRC, I can pickup.

@ghost ghost mentioned this pull request Sep 28, 2021
@ghost
Copy link
Author

ghost commented Jan 14, 2022

Reopened after reading this question: https://bitcoin.stackexchange.com/questions/111801/restrict-bitcoin-core-to-tor/

Change still makes sense, respect reviewers for their time to review and agree, hopeful this could get merged and improve docs.

@ghost ghost reopened this Jan 14, 2022
@katesalazar
Copy link
Contributor

I think this isn't a bad (nor a good) idea.

Because the Don't Repeat Yourself principle,
the affected lines shouldn't be edited manually,
but be assembled from their true sources
residing somewhere else.

@ghost
Copy link
Author

ghost commented Jan 18, 2022

image

I never realized this is mentioned somewhere in docs until I read it in one of the comments in some pull request. DNS is obviously important if discussing privacy so which doc would work better for users: 1 or 2?

I have also tried other things to highlight this but they were not acceptable to other reviewers: #22317 (comment)

@katesalazar
Copy link
Contributor

which doc would work better for users: 1 or 2?

for many users who would value better that doc be
perfectly synced to the program output, 2.

@ghost
Copy link
Author

ghost commented Jan 18, 2022

which doc would work better for users: 1 or 2?

for many users who would value better that doc be perfectly synced to the program output, 2.

Thanks for sharing your opinion. I disagree though and this doc can be improved a lot. This is one of the improvements which had some ACKs.

@achow101
Copy link
Member

ACK 86a4a15

@achow101 achow101 merged commit 869c6e2 into bitcoin:master Jan 18, 2022
sidhujag pushed a commit to syscoin/syscoin that referenced this pull request Jan 18, 2022
86a4a15 Highlight DNS request part (Prayank)

Pull request description:

  _What?_

  Highlight DNS requests part in Proxy section

  _Why?_

  1. DNS requests are very important while considering privacy
  2. Lot of users might skip reading it because of the way it is mixed with everything else in the doc right now
  3. I have seen lot of users ignoring DNS requests or unaware of such things while using privacy tools

  _How?_

  Initially I had tried keeping these lines separate from code block but [Jonatack didn't agree with the changes](bitcoin#21157 (comment)). Harding suggested using [bold/italic in `<pre></pre>`](bitcoin#21157 (comment)). I have used the suggestions from previous PR and added `---`

  This is a part of alternative described in bitcoin#22316

ACKs for top commit:
  jonatack:
    ACK 86a4a15
  Rspigler:
    ACK 86a4a15
  achow101:
    ACK 86a4a15
  RiccardoMasutti:
    ACK 86a4a15
  lsilva01:
    ACK bitcoin@86a4a15
  kristapsk:
    ACK 86a4a15
  theStack:
    ACK 86a4a15

Tree-SHA512: a4fe0e8c08df330e5ca78ce19ce74be7034c653f4374469d928908847a6debf385283e3a6da66de600566c7bab6290ccd35df26864aef94cbb3f294123391437
@bitcoin bitcoin locked and limited conversation to collaborators Apr 13, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

9 participants