Skip to content

build: Avoid fcntl64@GLIBC_2.28 in libsqlite3.a #22305

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
hebasto wants to merge 2 commits into from
Closed

build: Avoid fcntl64@GLIBC_2.28 in libsqlite3.a #22305

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f5b16ee
build: Avoid fcntl64@GLIBC_2.28 in libsqlite3.a
hebasto Jun 20, 2021
5384492
build: Bump minimum libc to 2.28 for 32-bit systems
hebasto Jun 21, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 7 additions & 2 deletions contrib/devtools/symbol-check.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,12 +39,17 @@
# GCC 4.8.5: GCC_4.8.0
# (glibc) GLIBC_2_17
#
# For 32-bit systems the minimum libc version is 2.28 to embrace new fcntl{64} symbols.
# It is safer than handling them in the glibc_compat.cpp due to their variadic arguments
# with possible different sizes.
# See: https://stackoverflow.com/a/58472959
#
MAX_VERSIONS = {
'GCC': (4,8,0),
'GLIBC': {
pixie.EM_386: (2,17),
pixie.EM_386: (2,28),
pixie.EM_X86_64: (2,17),
pixie.EM_ARM: (2,17),
pixie.EM_ARM: (2,28),
pixie.EM_AARCH64:(2,17),
pixie.EM_PPC64: (2,17),
pixie.EM_RISCV: (2,27),
Expand Down
1 change: 1 addition & 0 deletions depends/packages/sqlite.mk
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@ $(package)_sha256_hash=486748abfb16abd8af664e3a5f03b228e5f124682b0c942e157644bf6
define $(package)_set_vars
$(package)_config_opts=--disable-shared --disable-readline --disable-dynamic-extensions --enable-option-checking
$(package)_config_opts_linux=--with-pic
$(package)_cppflags_linux = -DSQLITE_DISABLE_LFS
endef

define $(package)_config_cmds
Expand Down