build, qt: Fix compiling qt package in depends with GCC 11 #22186

hebasto · 2021-06-08T01:35:30Z

The qt package in depends fails to compile with GCC 11 due to the missed <limits> headers.

See: https://bugreports.qt.io/browse/QTBUG-90395

Affected systems:

Ubuntu 21.04 + GCC 11.1.0
Fedora 34 + GCC 11.1.1

Ubuntu 21.04 build log excerpt:

Configuring qt...
Creating qmake...
gmake[1]: Entering directory '/home/hebasto/bitcoin/depends/work/build/x86_64-pc-linux-gnu/qt/5.12.11-1ff5c6c1f55/qtbase/qmake'
In file included from /home/hebasto/bitcoin/depends/work/build/x86_64-pc-linux-gnu/qt/5.12.11-1ff5c6c1f55/qtbase/include/QtCore/qendian.h:1,
                 from /home/hebasto/bitcoin/depends/work/build/x86_64-pc-linux-gnu/qt/5.12.11-1ff5c6c1f55/qtbase/src/corelib/codecs/qutfcodec.cpp:43:
/home/hebasto/bitcoin/depends/work/build/x86_64-pc-linux-gnu/qt/5.12.11-1ff5c6c1f55/qtbase/include/QtCore/../../src/corelib/global/qendian.h: In static member function ‘static constexpr QSpecialInteger<S> QSpecialInteger<S>::max()’:
/home/hebasto/bitcoin/depends/work/build/x86_64-pc-linux-gnu/qt/5.12.11-1ff5c6c1f55/qtbase/include/QtCore/../../src/corelib/global/qendian.h:331:35: error: ‘numeric_limits’ is not a member of ‘std’
  331 |     { return QSpecialInteger(std::numeric_limits<T>::max()); }
      |                                   ^~~~~~~~~~~~~~
/home/hebasto/bitcoin/depends/work/build/x86_64-pc-linux-gnu/qt/5.12.11-1ff5c6c1f55/qtbase/include/QtCore/../../src/corelib/global/qendian.h:331:54: error: ‘::max’ has not been declared; did you mean ‘std::max’?
  331 |     { return QSpecialInteger(std::numeric_limits<T>::max()); }
      |                                                      ^~~
      |                                                      std::max

DrahtBot · 2021-06-08T06:39:22Z

The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

Conflicts

Reviewers, this pull request conflicts with the following ones:

build: split depends Qt into native and target builds #22142 (build: split depends Qt into native and target builds by fanquake)
depends: Use Qt top-level build facilities #20641 (depends: Use Qt top-level build facilities by hebasto)

If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.

fanquake · 2021-06-09T05:00:37Z

Guix builds:

bash-5.1# find guix-build-$(git rev-parse --short=12 HEAD)/output/ -type f -print0 | env LC_ALL=C sort -z | xargs -r0 sha256sum
56c8da5cb1f260408cf9fc8cc9b3579a8594acb2333f4d00362e756481d7ff1b  guix-build-d1d1cc983146/output/aarch64-linux-gnu/bitcoin-d1d1cc983146-aarch64-linux-gnu-debug.tar.gz
bb58ad0641c2e0bd2ea4cd0bc09fb2c02c9fc799e2ea56621f2038bb9e0464a0  guix-build-d1d1cc983146/output/aarch64-linux-gnu/bitcoin-d1d1cc983146-aarch64-linux-gnu.tar.gz
0ff579d862a38bd1104b2ce5a21f85d507e04d06362cd25b41bf2116706bd3c6  guix-build-d1d1cc983146/output/aarch64-linux-gnu/inputs.SHA256SUMS
48e47fa77298d5f3828b468659011e24bef3798cc58a800cb433ebb90a090e78  guix-build-d1d1cc983146/output/arm-linux-gnueabihf/bitcoin-d1d1cc983146-arm-linux-gnueabihf-debug.tar.gz
ecf9e6f2fdd513342ddc92953586ce0957de0ef720f5d667c9fbae74adb465c5  guix-build-d1d1cc983146/output/arm-linux-gnueabihf/bitcoin-d1d1cc983146-arm-linux-gnueabihf.tar.gz
0ff579d862a38bd1104b2ce5a21f85d507e04d06362cd25b41bf2116706bd3c6  guix-build-d1d1cc983146/output/arm-linux-gnueabihf/inputs.SHA256SUMS
e3b0c44298fc1c149afbf4c8996fb92427ae41e4649b934ca495991b7852b855  guix-build-d1d1cc983146/output/dist-archive/SKIPATTEST.TAG
d566fea165cfba3d2bc7cf3e03209464b90ace7b2f4b64c990afcb773117d50c  guix-build-d1d1cc983146/output/dist-archive/bitcoin-d1d1cc983146.tar.gz
fd18a17e01691481b98712cb56f80bd8796cabc24c79d976fdcb65546f3be1e4  guix-build-d1d1cc983146/output/powerpc64-linux-gnu/bitcoin-d1d1cc983146-powerpc64-linux-gnu-debug.tar.gz
32cb46abb2e974352cb20decf02205ac07deb3f0769bd821e14ddefde0d5c523  guix-build-d1d1cc983146/output/powerpc64-linux-gnu/bitcoin-d1d1cc983146-powerpc64-linux-gnu.tar.gz
0ff579d862a38bd1104b2ce5a21f85d507e04d06362cd25b41bf2116706bd3c6  guix-build-d1d1cc983146/output/powerpc64-linux-gnu/inputs.SHA256SUMS
a984d9bae9c33dd7f2c0c9eeb8d8509c4bd7c231cd268c04bc71a8c2cb44214e  guix-build-d1d1cc983146/output/powerpc64le-linux-gnu/bitcoin-d1d1cc983146-powerpc64le-linux-gnu-debug.tar.gz
e8968956fedba9c6109cbfd40a2af2a5aa6f324f5d3e73c0e54024297a634052  guix-build-d1d1cc983146/output/powerpc64le-linux-gnu/bitcoin-d1d1cc983146-powerpc64le-linux-gnu.tar.gz
0ff579d862a38bd1104b2ce5a21f85d507e04d06362cd25b41bf2116706bd3c6  guix-build-d1d1cc983146/output/powerpc64le-linux-gnu/inputs.SHA256SUMS
e59258b63e14773a902e93a9b56cfe1dcc362fdf1a94489cfc256716ea62e8d3  guix-build-d1d1cc983146/output/riscv64-linux-gnu/bitcoin-d1d1cc983146-riscv64-linux-gnu-debug.tar.gz
2e8ea8e446f5de1ac7cda703a0e1a7c6c45f354cb9f75ca3fdf42e49841a8dbe  guix-build-d1d1cc983146/output/riscv64-linux-gnu/bitcoin-d1d1cc983146-riscv64-linux-gnu.tar.gz
0ff579d862a38bd1104b2ce5a21f85d507e04d06362cd25b41bf2116706bd3c6  guix-build-d1d1cc983146/output/riscv64-linux-gnu/inputs.SHA256SUMS
f97cf5498c7dcf41ee9e187dd49c2ebf6046d6e0a9164f0d08452f490b6246c3  guix-build-d1d1cc983146/output/x86_64-apple-darwin18/bitcoin-d1d1cc983146-osx-unsigned.dmg
8e973af8c8408e4c103f159d28288de72f5afad681e83949d822bd87a50d0c48  guix-build-d1d1cc983146/output/x86_64-apple-darwin18/bitcoin-d1d1cc983146-osx-unsigned.tar.gz
2aa752ab55a1dbeed370bceaf816b2a17c0f05f19e237115e65bf146d4e30b84  guix-build-d1d1cc983146/output/x86_64-apple-darwin18/bitcoin-d1d1cc983146-osx64.tar.gz
0ff579d862a38bd1104b2ce5a21f85d507e04d06362cd25b41bf2116706bd3c6  guix-build-d1d1cc983146/output/x86_64-apple-darwin18/inputs.SHA256SUMS
4465de183452ef89a0cdbe9d4c29867fad17cc9df965b8220cb1ca40089fa226  guix-build-d1d1cc983146/output/x86_64-linux-gnu/bitcoin-d1d1cc983146-x86_64-linux-gnu-debug.tar.gz
5871f4436f03f53069e2c6256d19942968d7185658ee285edf1796876553d1fc  guix-build-d1d1cc983146/output/x86_64-linux-gnu/bitcoin-d1d1cc983146-x86_64-linux-gnu.tar.gz
0ff579d862a38bd1104b2ce5a21f85d507e04d06362cd25b41bf2116706bd3c6  guix-build-d1d1cc983146/output/x86_64-linux-gnu/inputs.SHA256SUMS
f8c0dd0dd18256133c561763c32184671640b7f4db00fa7920a0a5d66ec099ac  guix-build-d1d1cc983146/output/x86_64-w64-mingw32/bitcoin-d1d1cc983146-win-unsigned.tar.gz
e60a3ad3ff5cfca2309ada1952dda7b1e76717e6981d3c222ea3515e46e2aa09  guix-build-d1d1cc983146/output/x86_64-w64-mingw32/bitcoin-d1d1cc983146-win64-debug.zip
f28b1dc6d4d5e115c60f2cf12431902ed4d54241230f0bbe9293b0e3e00c1c9b  guix-build-d1d1cc983146/output/x86_64-w64-mingw32/bitcoin-d1d1cc983146-win64-setup-unsigned.exe
3282a1c8bda8522336c19bf574bb0c6093b3a0d5dabe3d88f99d3c62b9d04752  guix-build-d1d1cc983146/output/x86_64-w64-mingw32/bitcoin-d1d1cc983146-win64.zip
0ff579d862a38bd1104b2ce5a21f85d507e04d06362cd25b41bf2116706bd3c6  guix-build-d1d1cc983146/output/x86_64-w64-mingw32/inputs.SHA256SUMS

fanquake · 2021-06-09T11:20:56Z

Gitian builds:

# macOS:
21acaab3b9f1b94746e7b05748c64236a86e60709f7470098beafd8541f00a3a  bitcoin-d1d1cc983146-osx-unsigned.dmg
a50ab21814742360207b2f89d9056259de8d61d1a7feb1a529d8f762b44aff45  bitcoin-d1d1cc983146-osx-unsigned.tar.gz
69b4d1fa5825e4e0c0e6e43a3dc05ceb870eb3c69eed2bd1718c0543b2977648  bitcoin-d1d1cc983146-osx64.tar.gz
d566fea165cfba3d2bc7cf3e03209464b90ace7b2f4b64c990afcb773117d50c  src/bitcoin-d1d1cc983146.tar.gz
fa62d560e307d1565182053183429f8e80f5a910cb2bf5da9d43169ad642eb66  bitcoin-core-osx-22-res.yml

# Windows:
8be1e2e48b461610d40211d9885e89829eb44c1243bc51208f6ba618b2327137  bitcoin-d1d1cc983146-win-unsigned.tar.gz
f7cc5e0ab8a8fbd62a6688af164b44f1a20f1da0628791c41c2ba292524fd7ae  bitcoin-d1d1cc983146-win64-debug.zip
08f7181dc91088fa20af4a4018a65b397dd9e3d77ff466322d90d8e21fe85922  bitcoin-d1d1cc983146-win64-setup-unsigned.exe
cdc82a359d77d19bbcc2647d76cdc2ce1f93e8294e478cebd4d22a77ad2a1e8d  bitcoin-d1d1cc983146-win64.zip
d566fea165cfba3d2bc7cf3e03209464b90ace7b2f4b64c990afcb773117d50c  src/bitcoin-d1d1cc983146.tar.gz
391381b3f6d5c62c8308b12052d3fc5c14b82be7b9ac625cd74690f0f8c6544d  bitcoin-core-win-22-res.yml

# Linux:
8b67e9e71701c721529b8623b538acebe0ddb3e66bd63a02145b07407bad3648  bitcoin-d1d1cc983146-aarch64-linux-gnu-debug.tar.gz
b09b988b94af56f30eea69364935547173f6caa43cbd608b24bf8e2dfda87a65  bitcoin-d1d1cc983146-aarch64-linux-gnu.tar.gz
c10592b488eea9e67f805b0ce2ada0216e29186222d7d837851dacf32535731a  bitcoin-d1d1cc983146-arm-linux-gnueabihf-debug.tar.gz
262a6143ed63ac1e9645a2df91968d3421cd261468a84eacc3aec774012d5867  bitcoin-d1d1cc983146-arm-linux-gnueabihf.tar.gz
e5d1a7f9683f289270c202f7d7ac771272fb857668c1d9b599dd1219a4691313  bitcoin-d1d1cc983146-powerpc64-linux-gnu-debug.tar.gz
cad1c80cad14293554d2a816e5d891fa94d5adfe844306622fba087999736f7a  bitcoin-d1d1cc983146-powerpc64-linux-gnu.tar.gz
18c1a388ee614692e603069055312458618f3f25825596bc9264d7183f933bf3  bitcoin-d1d1cc983146-powerpc64le-linux-gnu-debug.tar.gz
633c242871746686a7900708ce3b8cde3148270b8cecd068e267442240e4a35a  bitcoin-d1d1cc983146-powerpc64le-linux-gnu.tar.gz
b61a57080ceb7cef984e8d71cc91a49b7f5948fd05721744bb20fe6a246fe110  bitcoin-d1d1cc983146-riscv64-linux-gnu-debug.tar.gz
807930b58edbc870ceb6607223069f44fc10d23a1d0035a75175e090a6084fae  bitcoin-d1d1cc983146-riscv64-linux-gnu.tar.gz
26f8d9080a388015b69454e6c4e5c9fa61f275b3616932012a9953653db25fa6  bitcoin-d1d1cc983146-x86_64-linux-gnu-debug.tar.gz
26aaa250f45ced7edd413de4a236445db34fc7250b1aadb84e413cc2a1a80b8c  bitcoin-d1d1cc983146-x86_64-linux-gnu.tar.gz
d566fea165cfba3d2bc7cf3e03209464b90ace7b2f4b64c990afcb773117d50c  src/bitcoin-d1d1cc983146.tar.gz
99e3af2dc89391ded8119fac0faf0e2ca2ebd688c93de3dd3c278d0a0bfaa661  bitcoin-core-linux-22-res.yml

hebasto · 2021-06-09T11:42:49Z

Guix builds:

$ find guix-build-$(git rev-parse --short=12 HEAD)/output/ -type f -print0 | env LC_ALL=C sort -z | xargs -r0 sha256sum
56c8da5cb1f260408cf9fc8cc9b3579a8594acb2333f4d00362e756481d7ff1b  guix-build-d1d1cc983146/output/aarch64-linux-gnu/bitcoin-d1d1cc983146-aarch64-linux-gnu-debug.tar.gz
bb58ad0641c2e0bd2ea4cd0bc09fb2c02c9fc799e2ea56621f2038bb9e0464a0  guix-build-d1d1cc983146/output/aarch64-linux-gnu/bitcoin-d1d1cc983146-aarch64-linux-gnu.tar.gz
0ff579d862a38bd1104b2ce5a21f85d507e04d06362cd25b41bf2116706bd3c6  guix-build-d1d1cc983146/output/aarch64-linux-gnu/inputs.SHA256SUMS
48e47fa77298d5f3828b468659011e24bef3798cc58a800cb433ebb90a090e78  guix-build-d1d1cc983146/output/arm-linux-gnueabihf/bitcoin-d1d1cc983146-arm-linux-gnueabihf-debug.tar.gz
ecf9e6f2fdd513342ddc92953586ce0957de0ef720f5d667c9fbae74adb465c5  guix-build-d1d1cc983146/output/arm-linux-gnueabihf/bitcoin-d1d1cc983146-arm-linux-gnueabihf.tar.gz
0ff579d862a38bd1104b2ce5a21f85d507e04d06362cd25b41bf2116706bd3c6  guix-build-d1d1cc983146/output/arm-linux-gnueabihf/inputs.SHA256SUMS
e3b0c44298fc1c149afbf4c8996fb92427ae41e4649b934ca495991b7852b855  guix-build-d1d1cc983146/output/dist-archive/SKIPATTEST.TAG
d566fea165cfba3d2bc7cf3e03209464b90ace7b2f4b64c990afcb773117d50c  guix-build-d1d1cc983146/output/dist-archive/bitcoin-d1d1cc983146.tar.gz
fd18a17e01691481b98712cb56f80bd8796cabc24c79d976fdcb65546f3be1e4  guix-build-d1d1cc983146/output/powerpc64-linux-gnu/bitcoin-d1d1cc983146-powerpc64-linux-gnu-debug.tar.gz
32cb46abb2e974352cb20decf02205ac07deb3f0769bd821e14ddefde0d5c523  guix-build-d1d1cc983146/output/powerpc64-linux-gnu/bitcoin-d1d1cc983146-powerpc64-linux-gnu.tar.gz
0ff579d862a38bd1104b2ce5a21f85d507e04d06362cd25b41bf2116706bd3c6  guix-build-d1d1cc983146/output/powerpc64-linux-gnu/inputs.SHA256SUMS
a984d9bae9c33dd7f2c0c9eeb8d8509c4bd7c231cd268c04bc71a8c2cb44214e  guix-build-d1d1cc983146/output/powerpc64le-linux-gnu/bitcoin-d1d1cc983146-powerpc64le-linux-gnu-debug.tar.gz
e8968956fedba9c6109cbfd40a2af2a5aa6f324f5d3e73c0e54024297a634052  guix-build-d1d1cc983146/output/powerpc64le-linux-gnu/bitcoin-d1d1cc983146-powerpc64le-linux-gnu.tar.gz
0ff579d862a38bd1104b2ce5a21f85d507e04d06362cd25b41bf2116706bd3c6  guix-build-d1d1cc983146/output/powerpc64le-linux-gnu/inputs.SHA256SUMS
e59258b63e14773a902e93a9b56cfe1dcc362fdf1a94489cfc256716ea62e8d3  guix-build-d1d1cc983146/output/riscv64-linux-gnu/bitcoin-d1d1cc983146-riscv64-linux-gnu-debug.tar.gz
2e8ea8e446f5de1ac7cda703a0e1a7c6c45f354cb9f75ca3fdf42e49841a8dbe  guix-build-d1d1cc983146/output/riscv64-linux-gnu/bitcoin-d1d1cc983146-riscv64-linux-gnu.tar.gz
0ff579d862a38bd1104b2ce5a21f85d507e04d06362cd25b41bf2116706bd3c6  guix-build-d1d1cc983146/output/riscv64-linux-gnu/inputs.SHA256SUMS
f97cf5498c7dcf41ee9e187dd49c2ebf6046d6e0a9164f0d08452f490b6246c3  guix-build-d1d1cc983146/output/x86_64-apple-darwin18/bitcoin-d1d1cc983146-osx-unsigned.dmg
8e973af8c8408e4c103f159d28288de72f5afad681e83949d822bd87a50d0c48  guix-build-d1d1cc983146/output/x86_64-apple-darwin18/bitcoin-d1d1cc983146-osx-unsigned.tar.gz
2aa752ab55a1dbeed370bceaf816b2a17c0f05f19e237115e65bf146d4e30b84  guix-build-d1d1cc983146/output/x86_64-apple-darwin18/bitcoin-d1d1cc983146-osx64.tar.gz
0ff579d862a38bd1104b2ce5a21f85d507e04d06362cd25b41bf2116706bd3c6  guix-build-d1d1cc983146/output/x86_64-apple-darwin18/inputs.SHA256SUMS
4465de183452ef89a0cdbe9d4c29867fad17cc9df965b8220cb1ca40089fa226  guix-build-d1d1cc983146/output/x86_64-linux-gnu/bitcoin-d1d1cc983146-x86_64-linux-gnu-debug.tar.gz
5871f4436f03f53069e2c6256d19942968d7185658ee285edf1796876553d1fc  guix-build-d1d1cc983146/output/x86_64-linux-gnu/bitcoin-d1d1cc983146-x86_64-linux-gnu.tar.gz
0ff579d862a38bd1104b2ce5a21f85d507e04d06362cd25b41bf2116706bd3c6  guix-build-d1d1cc983146/output/x86_64-linux-gnu/inputs.SHA256SUMS
f8c0dd0dd18256133c561763c32184671640b7f4db00fa7920a0a5d66ec099ac  guix-build-d1d1cc983146/output/x86_64-w64-mingw32/bitcoin-d1d1cc983146-win-unsigned.tar.gz
e60a3ad3ff5cfca2309ada1952dda7b1e76717e6981d3c222ea3515e46e2aa09  guix-build-d1d1cc983146/output/x86_64-w64-mingw32/bitcoin-d1d1cc983146-win64-debug.zip
f28b1dc6d4d5e115c60f2cf12431902ed4d54241230f0bbe9293b0e3e00c1c9b  guix-build-d1d1cc983146/output/x86_64-w64-mingw32/bitcoin-d1d1cc983146-win64-setup-unsigned.exe
3282a1c8bda8522336c19bf574bb0c6093b3a0d5dabe3d88f99d3c62b9d04752  guix-build-d1d1cc983146/output/x86_64-w64-mingw32/bitcoin-d1d1cc983146-win64.zip
0ff579d862a38bd1104b2ce5a21f85d507e04d06362cd25b41bf2116706bd3c6  guix-build-d1d1cc983146/output/x86_64-w64-mingw32/inputs.SHA256SUMS

hebasto · 2021-06-09T13:54:02Z

Gitian builds:

Linux:

Generating report
8b67e9e71701c721529b8623b538acebe0ddb3e66bd63a02145b07407bad3648  bitcoin-d1d1cc983146-aarch64-linux-gnu-debug.tar.gz
b09b988b94af56f30eea69364935547173f6caa43cbd608b24bf8e2dfda87a65  bitcoin-d1d1cc983146-aarch64-linux-gnu.tar.gz
c10592b488eea9e67f805b0ce2ada0216e29186222d7d837851dacf32535731a  bitcoin-d1d1cc983146-arm-linux-gnueabihf-debug.tar.gz
262a6143ed63ac1e9645a2df91968d3421cd261468a84eacc3aec774012d5867  bitcoin-d1d1cc983146-arm-linux-gnueabihf.tar.gz
e5d1a7f9683f289270c202f7d7ac771272fb857668c1d9b599dd1219a4691313  bitcoin-d1d1cc983146-powerpc64-linux-gnu-debug.tar.gz
cad1c80cad14293554d2a816e5d891fa94d5adfe844306622fba087999736f7a  bitcoin-d1d1cc983146-powerpc64-linux-gnu.tar.gz
18c1a388ee614692e603069055312458618f3f25825596bc9264d7183f933bf3  bitcoin-d1d1cc983146-powerpc64le-linux-gnu-debug.tar.gz
633c242871746686a7900708ce3b8cde3148270b8cecd068e267442240e4a35a  bitcoin-d1d1cc983146-powerpc64le-linux-gnu.tar.gz
b61a57080ceb7cef984e8d71cc91a49b7f5948fd05721744bb20fe6a246fe110  bitcoin-d1d1cc983146-riscv64-linux-gnu-debug.tar.gz
807930b58edbc870ceb6607223069f44fc10d23a1d0035a75175e090a6084fae  bitcoin-d1d1cc983146-riscv64-linux-gnu.tar.gz
26f8d9080a388015b69454e6c4e5c9fa61f275b3616932012a9953653db25fa6  bitcoin-d1d1cc983146-x86_64-linux-gnu-debug.tar.gz
26aaa250f45ced7edd413de4a236445db34fc7250b1aadb84e413cc2a1a80b8c  bitcoin-d1d1cc983146-x86_64-linux-gnu.tar.gz
d566fea165cfba3d2bc7cf3e03209464b90ace7b2f4b64c990afcb773117d50c  src/bitcoin-d1d1cc983146.tar.gz
fed37ad93d78ca1412f618689e0086e7cdb0469ef515381021d35eb36835bae9  bitcoin-core-linux-22-res.yml
Done.

Windows:

Generating report
8be1e2e48b461610d40211d9885e89829eb44c1243bc51208f6ba618b2327137  bitcoin-d1d1cc983146-win-unsigned.tar.gz
f7cc5e0ab8a8fbd62a6688af164b44f1a20f1da0628791c41c2ba292524fd7ae  bitcoin-d1d1cc983146-win64-debug.zip
08f7181dc91088fa20af4a4018a65b397dd9e3d77ff466322d90d8e21fe85922  bitcoin-d1d1cc983146-win64-setup-unsigned.exe
cdc82a359d77d19bbcc2647d76cdc2ce1f93e8294e478cebd4d22a77ad2a1e8d  bitcoin-d1d1cc983146-win64.zip
d566fea165cfba3d2bc7cf3e03209464b90ace7b2f4b64c990afcb773117d50c  src/bitcoin-d1d1cc983146.tar.gz
0871cdb2655c9ee49f4bc6f892f6bac5430d0fa983cd795fa2844b669bc87611  bitcoin-core-win-22-res.yml
Done.

macOS:

Generating report
21acaab3b9f1b94746e7b05748c64236a86e60709f7470098beafd8541f00a3a  bitcoin-d1d1cc983146-osx-unsigned.dmg
a50ab21814742360207b2f89d9056259de8d61d1a7feb1a529d8f762b44aff45  bitcoin-d1d1cc983146-osx-unsigned.tar.gz
69b4d1fa5825e4e0c0e6e43a3dc05ceb870eb3c69eed2bd1718c0543b2977648  bitcoin-d1d1cc983146-osx64.tar.gz
d566fea165cfba3d2bc7cf3e03209464b90ace7b2f4b64c990afcb773117d50c  src/bitcoin-d1d1cc983146.tar.gz
2fc3eedd82e0d1586c379e9e3278c489f0788f3b6f1ca6c1a802eebbbea3114e  bitcoin-core-osx-22-res.yml
Done.

DrahtBot · 2021-06-09T22:39:18Z

Guix builds

File	commit `76d4018` (master)	commit 14db7bf17bfbbca08f8a4abdf1b527825ac17a2c (master and this pull)
SKIPATTEST.TAG	`e3b0c44298fc1c14...`	`e3b0c44298fc1c14...`
*-aarch64-linux-gnu-debug.tar.gz	`64d3df3c2476d44b...`	`ae80a6dd60c22e87...`
*-aarch64-linux-gnu.tar.gz	`267cfbaa44b53ee9...`	`d301437ca28d61e7...`
*-arm-linux-gnueabihf-debug.tar.gz	`c61f3e6ef879fa74...`	`25679936ebe2035c...`
*-arm-linux-gnueabihf.tar.gz	`8b97d310ab5a8557...`	`3d9c971ec418fe4d...`
*-osx-unsigned.dmg	`daa3f9040ec779fa...`	`f9ccf8f4f039d3f9...`
*-osx-unsigned.tar.gz	`76fde3b8e87bbc9f...`	`3d42c423fa4bcee4...`
*-osx64.tar.gz	`36b8fb1bdbaa27e3...`	`9a58119e3a73eb69...`
*-powerpc64-linux-gnu-debug.tar.gz	`97d205c3613714e2...`	`abdda4f27a684a90...`
*-powerpc64-linux-gnu.tar.gz	`f4da65fda6455702...`	`0b9ed740e092f15b...`
*-powerpc64le-linux-gnu-debug.tar.gz	`a1312bf1da20d4bc...`	`040ef6a2efbcfcb0...`
*-powerpc64le-linux-gnu.tar.gz	`e1fe1700a6585c32...`	`7a9957276cb84565...`
*-riscv64-linux-gnu-debug.tar.gz	`123da856aafa7617...`	`4f4e509eca57886d...`
*-riscv64-linux-gnu.tar.gz	`ed5bc2adb03fd73e...`	`15cee90a7d6712b6...`
*-win-unsigned.tar.gz	`a0bb3d07c10e0ad0...`	`8f8144598e13d643...`
*-win64-debug.zip	`40164e389e1200f8...`	`77f103050300c65d...`
*-win64-setup-unsigned.exe	`3b7ccd1e585e1cb5...`	`2e6332e250e013ee...`
*-win64.zip	`aaf196e4147c0553...`	`a8065e6bc9a74241...`
*-x86_64-linux-gnu-debug.tar.gz	`42c7ffa757f3c023...`	`40e2f9bc97eebb23...`
*-x86_64-linux-gnu.tar.gz	`66ea519c0474f5a9...`	`9e68d4c45d9dfc5c...`
*.tar.gz	`7c62d52f287dd223...`	`054fe8b59b037d59...`
guix_build.log	`2b47ee2b28b87c20...`	`6f63a1086e8d9fa7...`
inputs.SHA256SUMS	`4584c539947b2528...`	`a140a48474fb6894...`
guix_build.log.diff		`ddec483646d493fc...`

fanquake

ACK d1d1cc9

…ith GCC 11 d1d1cc9 build, qt: Fix compiling qt package in depends with GCC 11 (Hennadii Stepanov) Pull request description: The `qt` package in depends fails to compile with GCC 11 due to the missed `<limits>` headers. See: https://bugreports.qt.io/browse/QTBUG-90395 Affected systems: - Ubuntu 21.04 + GCC 11.1.0 - Fedora 34 + GCC 11.1.1 Ubuntu 21.04 build log excerpt: ``` Configuring qt... Creating qmake... gmake[1]: Entering directory '/home/hebasto/bitcoin/depends/work/build/x86_64-pc-linux-gnu/qt/5.12.11-1ff5c6c1f55/qtbase/qmake' In file included from /home/hebasto/bitcoin/depends/work/build/x86_64-pc-linux-gnu/qt/5.12.11-1ff5c6c1f55/qtbase/include/QtCore/qendian.h:1, from /home/hebasto/bitcoin/depends/work/build/x86_64-pc-linux-gnu/qt/5.12.11-1ff5c6c1f55/qtbase/src/corelib/codecs/qutfcodec.cpp:43: /home/hebasto/bitcoin/depends/work/build/x86_64-pc-linux-gnu/qt/5.12.11-1ff5c6c1f55/qtbase/include/QtCore/../../src/corelib/global/qendian.h: In static member function ‘static constexpr QSpecialInteger<S> QSpecialInteger<S>::max()’: /home/hebasto/bitcoin/depends/work/build/x86_64-pc-linux-gnu/qt/5.12.11-1ff5c6c1f55/qtbase/include/QtCore/../../src/corelib/global/qendian.h:331:35: error: ‘numeric_limits’ is not a member of ‘std’ 331 | { return QSpecialInteger(std::numeric_limits<T>::max()); } | ^~~~~~~~~~~~~~ /home/hebasto/bitcoin/depends/work/build/x86_64-pc-linux-gnu/qt/5.12.11-1ff5c6c1f55/qtbase/include/QtCore/../../src/corelib/global/qendian.h:331:54: error: ‘::max’ has not been declared; did you mean ‘std::max’? 331 | { return QSpecialInteger(std::numeric_limits<T>::max()); } | ^~~ | std::max ``` ACKs for top commit: fanquake: ACK d1d1cc9 Tree-SHA512: 2dd643efc0aefc492f9565c0900ba0f1657c016bc4a44792f85478b9fc6e0e4ecad78847114ef6ec702d2de4cdbc3f657e9b96634ea58f42b6cc98dfb5e09eab

DrahtBot · 2021-06-11T02:51:46Z

Gitian builds

File	commit `46424e9` (master)	commit 2ab8e80a1749448a5b7c00858be88351de654979 (master and this pull)
*-aarch64-linux-gnu-debug.tar.gz	`4b7e7633e627f699...`	`ffcbbe861107008c...`
*-aarch64-linux-gnu.tar.gz	`3a3d53bb6374bdbd...`	`e44ea0cd9fa27e22...`
*-arm-linux-gnueabihf-debug.tar.gz	`50265faa89ee001e...`	`551fd81399ed3936...`
*-arm-linux-gnueabihf.tar.gz	`d97ffcf66a08d4ce...`	`34323242deb8f12b...`
*-osx-unsigned.dmg	`83aaffa16bfe2d41...`	`f6fe14a1ca4b5d73...`
*-osx64.tar.gz	`b9825f6980a8b699...`	`ca8ef6daf934f646...`
*-powerpc64-linux-gnu-debug.tar.gz	`c76c4332db7a61a8...`	`ef0bde1b10bdbc59...`
*-powerpc64-linux-gnu.tar.gz	`9dbed12500c86c35...`	`60052acb15c20eac...`
*-powerpc64le-linux-gnu-debug.tar.gz	`a63f23ae632a135a...`	`6913e5a331f83094...`
*-powerpc64le-linux-gnu.tar.gz	`6950613b9947f006...`	`07ac2a71da2b1ffa...`
*-riscv64-linux-gnu-debug.tar.gz	`c35378221620365f...`	`fffb64affd6512d7...`
*-riscv64-linux-gnu.tar.gz	`2afe7db9fbb335af...`	`c5f120990194c8c2...`
*-win64-debug.zip	`7d56f4957c6549c2...`	`0f9142e0df80112f...`
*-win64-setup-unsigned.exe	`e707fe4c3d3b974d...`	`5f3a40c5f6b546fd...`
*-win64.zip	`ced79e7246e57589...`	`89ea28b700aced41...`
*-x86_64-linux-gnu-debug.tar.gz	`28299e1f9c83cfd9...`	`f2055def9646c38d...`
*-x86_64-linux-gnu.tar.gz	`e025a5503033f73f...`	`7d303611335044f6...`
*.tar.gz	`873a567f7935969b...`	`33118da17bab9918...`
bitcoin-core-linux-22-res.yml	`31b6f4fe13045d0b...`	`252405449a8e1988...`
bitcoin-core-osx-22-res.yml	`a24f6cf31d9b547f...`	`0361f6977b611911...`
bitcoin-core-win-22-res.yml	`f516cbae3de83356...`	`f7e4eb9c824104a4...`
linux-build.log	`e03c11fe5fef6620...`	`fb3f9b62f64a024b...`
osx-build.log	`d8f1de850eccd7ff...`	`2b03fefca646c680...`
win-build.log	`6969f951ea98a62d...`	`f4283ca458dfc974...`
bitcoin-core-linux-22-res.yml.diff		`20a3e12151ae3724...`
bitcoin-core-osx-22-res.yml.diff		`0f00f5528cf7dbbf...`
bitcoin-core-win-22-res.yml.diff		`09ebac6eea7dff7f...`
linux-build.log.diff		`1af4f26f54595da8...`
osx-build.log.diff		`c4f8696f76f53919...`
win-build.log.diff		`8be2b0c9547b03b6...`

…4386)

26ce35f build, qml: Fix compiling with GCC 11 (Hennadii Stepanov) Pull request description: Currently (a8dbc01), building the `qt` package in depends with GCC 11 fails: ``` $ gcc --version gcc (Ubuntu 11.1.0-1ubuntu1~21.04) 11.1.0 Copyright (C) 2021 Free Software Foundation, Inc. This is free software; see the source for copying conditions. There is NO warranty; not even for MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. $ make -C depends qt ... In file included from ../../include/QtQml/5.12.11/QtQml/private/qv4propertykey_p.h:1, from ../../include/QtQml/5.12.11/QtQml/private/../../../../../src/qml/jsruntime/qv4internalclass_p.h:56, from ../../include/QtQml/5.12.11/QtQml/private/qv4internalclass_p.h:1, from ../qml/jsruntime/qv4value_p.h:59, from ../qml/jsruntime/qv4managed_p.h:54, from ../qml/jsruntime/qv4engine_p.h:54, from ../qml/jsruntime/qv4engine.cpp:39: ../../include/QtQml/5.12.11/QtQml/private/../../../../../src/qml/jsruntime/qv4propertykey_p.h: In member function ‘uint QV4::PropertyKey::asArrayIndex() const’: ../../include/QtQml/5.12.11/QtQml/private/../../../../../src/qml/jsruntime/qv4propertykey_p.h:116:73: error: ‘numeric_limits’ is not a member of ‘std’ 116 | uint asArrayIndex() const { return (isManaged() || val == 0) ? std::numeric_limits<uint>::max() : static_cast<uint>(val & 0xffffffff); } | ^~~~~~~~~~~~~~ ../../include/QtQml/5.12.11/QtQml/private/../../../../../src/qml/jsruntime/qv4propertykey_p.h:116:92: error: expected primary-expression before ‘>’ token 116 | uint asArrayIndex() const { return (isManaged() || val == 0) ? std::numeric_limits<uint>::max() : static_cast<uint>(val & 0xffffffff); } | ^ ../../include/QtQml/5.12.11/QtQml/private/../../../../../src/qml/jsruntime/qv4propertykey_p.h:116:95: error: ‘::max’ has not been declared; did you mean ‘std::max’? 116 | uint asArrayIndex() const { return (isManaged() || val == 0) ? std::numeric_limits<uint>::max() : static_cast<uint>(val & 0xffffffff); } | ^~~ | std::max ``` This is similar to the bitcoin/bitcoin#22186. ACKs for top commit: promag: utACK 26ce35f. Including `<limits>` should fix error in OP. Tree-SHA512: 1706be13d347e26ebad8029ed5c68719d814b291175afb0de7654a5810f52f8d31d970db329355658dbdc31b58a0c2dc759f3718752ac42d30858f602beac2b6

…ashpay#4386)

build, qt: Fix compiling qt package in depends with GCC 11

d1d1cc9

fanquake added the Build system label Jun 8, 2021

maflcko added Needs gitian build DrahtBot Guix build requested labels Jun 8, 2021

DrahtBot removed the DrahtBot Guix build requested label Jun 9, 2021

fanquake approved these changes Jun 10, 2021

View reviewed changes

fanquake merged commit 92584d2 into bitcoin:master Jun 10, 2021

hebasto deleted the 210608-limits branch June 10, 2021 01:56

maflcko removed the Needs gitian build label Jun 10, 2021

DrahtBot mentioned this pull request Jun 10, 2021

depends: Use Qt top-level build facilities #20641

Merged

div72 mentioned this pull request Jul 15, 2021

depends: patch missing include in qt gridcoin-community/Gridcoin-Research#2234

Merged

kwvg added a commit to kwvg/dash that referenced this pull request Sep 2, 2021

merge bitcoin#22186: Fix compiling qt package in depends with GCC 11

7fb7b14

PastaPastaPasta pushed a commit to dashpay/dash that referenced this pull request Sep 2, 2021

merge bitcoin#22186: Fix compiling qt package in depends with GCC 11 (#…

cc03953

…4386)

hebasto mentioned this pull request Oct 10, 2021

build: Fix compiling with GCC 11 bitcoin-core/gui-qml#53

Merged

gades pushed a commit to cosanta/cosanta-core that referenced this pull request Apr 20, 2022

merge bitcoin#22186: Fix compiling qt package in depends with GCC 11 (d…

262f671

…ashpay#4386)

gwillen pushed a commit to ElementsProject/elements that referenced this pull request Jun 1, 2022

Merge 92584d2 into merged_master (Bitcoin PR bitcoin/bitcoin#22186)

2d998f6

bitcoin locked as resolved and limited conversation to collaborators Aug 16, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

build, qt: Fix compiling qt package in depends with GCC 11 #22186

build, qt: Fix compiling qt package in depends with GCC 11 #22186

Uh oh!

hebasto commented Jun 8, 2021 •

edited

Loading

Uh oh!

DrahtBot commented Jun 8, 2021 •

edited

Loading

Uh oh!

fanquake commented Jun 9, 2021

Uh oh!

fanquake commented Jun 9, 2021

Uh oh!

hebasto commented Jun 9, 2021

Uh oh!

hebasto commented Jun 9, 2021 •

edited

Loading

Uh oh!

DrahtBot commented Jun 9, 2021

Uh oh!

fanquake left a comment

Uh oh!

DrahtBot commented Jun 11, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

build, qt: Fix compiling qt package in depends with GCC 11 #22186

build, qt: Fix compiling qt package in depends with GCC 11 #22186

Uh oh!

Conversation

hebasto commented Jun 8, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

DrahtBot commented Jun 8, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Conflicts

Uh oh!

fanquake commented Jun 9, 2021

Uh oh!

fanquake commented Jun 9, 2021

Uh oh!

hebasto commented Jun 9, 2021

Guix builds:

Uh oh!

hebasto commented Jun 9, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Gitian builds:

Uh oh!

DrahtBot commented Jun 9, 2021

Guix builds

Uh oh!

fanquake left a comment

Choose a reason for hiding this comment

Uh oh!

DrahtBot commented Jun 11, 2021

Gitian builds

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

hebasto commented Jun 8, 2021 •

edited

Loading

DrahtBot commented Jun 8, 2021 •

edited

Loading

hebasto commented Jun 9, 2021 •

edited

Loading