Skip to content

doc: update tor.md, release notes with removal of tor v2 support #22172

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
laanwj merged 2 commits into from
Jun 12, 2021
Merged

doc: update tor.md, release notes with removal of tor v2 support #22172

laanwj merged 2 commits into from
Jun 12, 2021

Conversation

@jonatack
Copy link
Member

@jonatack jonatack commented Jun 6, 2021

Follow-up documentation to #22050 that removed support for Tor version 2 hidden services from Bitcoin Core.

@DrahtBot DrahtBot added the Docs label Jun 6, 2021
jarolrod
jarolrod reviewed Jun 6, 2021
View reviewed changes
@jarolrod
Copy link
Contributor

jarolrod commented Jun 6, 2021

ACK 83d75d21b5d9811cf04cb3c0f51b588a7ec7097e

@DrahtBot
Copy link
Contributor

DrahtBot commented Jun 6, 2021

The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

Conflicts

Reviewers, this pull request conflicts with the following ones:

If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.

@DrahtBot DrahtBot mentioned this pull request Jun 7, 2021
Closed
@Zero-1729
Copy link
Contributor

Zero-1729 commented Jun 7, 2021 •
edited
Loading

ACK 83d75d21b5d9811cf04cb3c0f51b588a7ec7097e, looks good.

ghost
ghost approved these changes Jun 7, 2021
View reviewed changes
Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK 83d75d2

@ghost ghost mentioned this pull request Jun 9, 2021
Merged
klementtan
klementtan approved these changes Jun 10, 2021
View reviewed changes
Copy link
Contributor

@klementtan klementtan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK 83d75d2

laanwj
laanwj reviewed Jun 12, 2021
View reviewed changes
doc/release-notes.md Outdated
Copy link
Member

@laanwj laanwj Jun 12, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think changes to maintainer-facing tools such as generate-seeds need to be in the release notes. Not a big deal though.

Copy link
Member Author

@jonatack jonatack Jun 12, 2021 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good point, removed.

FWIW if #22179 is merged, I planned to append its PR number to this entry manually in the wiki.

@jonatack jonatack force-pushed the tor-v2-removal-documentation branch from 83d75d2 to 2ad034a Compare June 12, 2021 10:09
@laanwj
Copy link
Member

laanwj commented Jun 12, 2021

ACK 2ad034a

@laanwj laanwj merged commit 4bff49b into bitcoin:master Jun 12, 2021
@jonatack jonatack deleted the tor-v2-removal-documentation branch June 12, 2021 10:26
sidhujag pushed a commit to syscoin/syscoin that referenced this pull request Jun 13, 2021
@laanwj
Merge bitcoin#22172: doc: update tor.md, release notes with removal o…
d17f356 
…f tor v…
furszy added a commit to furszy/bitcoin-core that referenced this pull request Aug 10, 2021
@furszy
Doc: update tor.md with latest upstream information.
0b5f406 
Combination of upstream's bitcoin#19961, bitcoin#21753 and bitcoin#22172
@daira daira mentioned this pull request Aug 23, 2021
Open
gwillen pushed a commit to ElementsProject/elements that referenced this pull request Jun 1, 2022
@apoelstra
Merge 4bff49b into merged_master (Bitcoin PR bitcoin/bitcoin#22172)
150d759
@bitcoin bitcoin locked as resolved and limited conversation to collaborators Aug 16, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@laanwj laanwj laanwj left review comments

+4 more reviewers

@jarolrod jarolrod jarolrod left review comments

@Zero-1729 Zero-1729 Zero-1729 approved these changes

@klementtan klementtan klementtan approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

Docs

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@jonatack @jarolrod @DrahtBot @Zero-1729 @laanwj @klementtan