Skip to content

Conversation

@maflcko
Copy link
Member

@maflcko maflcko commented Jun 2, 2021

Closes #22068

This also removes the "brew update" added in commit
b738155.
@fanquake fanquake added the Tests label Jun 2, 2021
@fanquake
Copy link
Member

fanquake commented Jun 2, 2021

Concept ACK. 2 minutes spent installing packages is better than 8+.

Copy link
Contributor

@promag promag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Concept ACK

Copy link
Member

@hebasto hebasto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK faa8dfd, I have reviewed the code and it looks OK, I agree it can be merged, and the Cirrus CI is green.

@maflcko maflcko merged commit fd7a770 into bitcoin:master Jun 3, 2021
@maflcko maflcko deleted the 2106-ciMac branch June 3, 2021 05:47
sidhujag pushed a commit to syscoin/syscoin that referenced this pull request Jun 3, 2021
faa8dfd ci: Bump macOS image to big-sur-xcode-12.5 (MarcoFalke)

Pull request description:

  Closes bitcoin#22068

ACKs for top commit:
  hebasto:
    ACK faa8dfd, I have reviewed the code and it looks OK, I agree it can be merged, and the Cirrus CI is green.

Tree-SHA512: e29f6290163f3727f3603a3d6b4cf47677f6b02fff370e8d9073962a42bd7ab1ae8d247306e4c41bcadf0a208784344a6229627fe1a883b1e5112df30ea88635
apoelstra pushed a commit to apoelstra/elements that referenced this pull request Jul 11, 2021
This also removes the "brew update" added in commit
b738155.

bitcoin/bitcoin#22122 (1/1)
apoelstra pushed a commit to apoelstra/elements that referenced this pull request Jul 11, 2021
This also removes the "brew update" added in commit
b738155.

bitcoin/bitcoin#22122 (1/1)
apoelstra pushed a commit to apoelstra/elements that referenced this pull request Jul 11, 2021
This also removes the "brew update" added in commit
b738155.

bitcoin/bitcoin#22122 (1/1)
stevenroose added a commit to ElementsProject/elements that referenced this pull request Jul 12, 2021
1e63e57 ci: disable Werror on MacOS build (not a backport) (Andrew Poelstra)
1852f83 ci: Bump macOS image to big-sur-xcode-12.5 (MarcoFalke)
4f33ba7 ci: Fix macOS brew install command (Hennadii Stepanov)
0265085 ci: Bump macOS VM image to the latest version (Hennadii Stepanov)
0740cee ci: Adjust cirrus ci task names (Andrew Poelstra)
d08e584 ci: Fix doc typos in .cirrus.yml (Andrew Poelstra)
953cbe2 ci: Run nowallet ci config on cirrus (MarcoFalke)
60a5632 build: set minimum supported macOS to 10.14 (fanquake)

Pull request description:

  Backport of bitcoin/bitcoin#20419 then bitcoin/bitcoin#19179 (except 2nd commit "Run i686 centos ci config on cirrus" which requires some more supporting PRs) then bitcoin/bitcoin#20545 then bitcoin/bitcoin#21542 then
  bitcoin/bitcoin#21663 then bitcoin/bitcoin#22122

  We are getting 403 errors in our MacOS job on Cirrus, presumably because bintray.com has shut down (see discussion on upstream PR 21663). Backport this PR and several supporting ones. These PRs will be merged as part of the 22.0 rebase. In the interest of keeping CI running let's backport them early.

Top commit has no ACKs.

Tree-SHA512: cdfe96789adedbfb617cdafb534175323a8fd46606e67adf7053f97cc32712dd3ece850906b522b6b0bed137f52c1372319f52f4a7b303aec479ea54d213271c
gwillen pushed a commit to ElementsProject/elements that referenced this pull request Jun 1, 2022
@bitcoin bitcoin locked as resolved and limited conversation to collaborators Aug 16, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

ci: wasted time in brew_install stage of macOS native build

4 participants