Wallet registration locks in main.cpp + UnregisterAllWallet() function #2209
Conversation
There was a problem hiding this comment.
Is cs_setpwalletRegistered allready defined somewhere? Just a quick question ^^.
There was a problem hiding this comment.
Yes, in fact this already existed in master HEAD...but only RegisterWallet() and UnregisterWallet() were using the lock.
|
Automatic sanity-testing: PASSED, see http://jenkins.bluematt.me/pull-tester/52c4988344ccaa8b2d400f3c15f66460fcd3149a for binaries and test log. |
|
Automatic sanity-testing: PASSED, see http://jenkins.bluematt.me/pull-tester/128599e1d27aa47985d6fc8997a2d41ffe77867d for binaries and test log. |
|
ACK |
|
Please rebase. |
…ed an UnregisterAllWallets function.
|
ACK |
Wallet registration locks in main.cpp + UnregisterAllWallet() function
5 participants
Right now in the current master these hooks aren't really being used - a single wallet is registered at startup in init.cpp and is unregistered at shutdown, also in init.cpp. But in order to support dynamic loading and unloading of transaction listeners, it is necessary to lock these functions. It is also convenient to have an UnregisterAllWallets() function and to call that upon shutdown instead of just calling it on the single main wallet that master currently has.