build: don't use cf-protection when targeting arm-apple-darwin #22070
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
After two reports on IRC of issues building depends on an Apple M1 machine, it turns out that this option can't be used when targeting arm-apple-darwin. For now, just use it for x86_64-apple-darwin. ```bash Apple clang version 12.0.5 (clang-1205.0.22.9) Target: x86_64-apple-darwin20.4.0 error: option 'cf-protection=return' cannot be specified on this target error: option 'cf-protection=branch' cannot be specified on this target 2 errors generated. ```
fanquake
added a commit
that referenced
this pull request
May 28, 2021
7e2a989 depends: latest config.sub (2021-04-30) (fanquake) f16d4cd depends: latest config.guess (2021-05-24) (fanquake) Pull request description: This is split out of #21851. Updating these files should be mechanical, and shouldn't have to wait for that PR. Also, having support in depends for the new `arm-apple-darwin` target (added in [2593751ef276497e312d7c4ce7fd049614c7bf80](https://git.savannah.gnu.org/cgit/config.git/commit/?id=2593751ef276497e312d7c4ce7fd049614c7bf80)) is useful when debugging. i.e #22070. If you try and compile depends for a `arm-apple-darwin` target using master, on a x86_64 darwin machine, currently you'll get: ```bash gmake -C depends -j9 HOST=arm64-apple-darwin Invalid configuration `arm64-apple-darwin': machine `arm64-apple' not recognized shasum: hosts/.mk: No such file or directory <omitted> Makefile:111: hosts/.mk: No such file or directory gmake: *** No rule to make target 'hosts/.mk'. Stop. ``` ACKs for top commit: laanwj: ACK 7e2a989 Tree-SHA512: 8ed99b5d486c6cbca8929a752460338b6ee17f6bf93013c76589605678853c3a01ebd631b4d3f5d6aaeb6e5c21b7bbe39afc4454d3a697fafb27678f6d2c021e
promag
reviewed
May 28, 2021
sidhujag
pushed a commit
to syscoin/syscoin
that referenced
this pull request
May 28, 2021
7e2a989 depends: latest config.sub (2021-04-30) (fanquake) f16d4cd depends: latest config.guess (2021-05-24) (fanquake) Pull request description: This is split out of bitcoin#21851. Updating these files should be mechanical, and shouldn't have to wait for that PR. Also, having support in depends for the new `arm-apple-darwin` target (added in [2593751ef276497e312d7c4ce7fd049614c7bf80](https://git.savannah.gnu.org/cgit/config.git/commit/?id=2593751ef276497e312d7c4ce7fd049614c7bf80)) is useful when debugging. i.e bitcoin#22070. If you try and compile depends for a `arm-apple-darwin` target using master, on a x86_64 darwin machine, currently you'll get: ```bash gmake -C depends -j9 HOST=arm64-apple-darwin Invalid configuration `arm64-apple-darwin': machine `arm64-apple' not recognized shasum: hosts/.mk: No such file or directory <omitted> Makefile:111: hosts/.mk: No such file or directory gmake: *** No rule to make target 'hosts/.mk'. Stop. ``` ACKs for top commit: laanwj: ACK 7e2a989 Tree-SHA512: 8ed99b5d486c6cbca8929a752460338b6ee17f6bf93013c76589605678853c3a01ebd631b4d3f5d6aaeb6e5c21b7bbe39afc4454d3a697fafb27678f6d2c021e
Contributor
sidhujag
pushed a commit
to syscoin/syscoin
that referenced
this pull request
Jun 1, 2021
…m-apple-darwin 3caedb4 build: don't use cf-protection when targeting arm-apple-darwin (fanquake) Pull request description: After two reports on IRC of issues building depends on an Apple M1 machine, this option (obviously) can't be used when targeting `arm-apple-darwin`. For now, just use it for `x86_64-apple-darwin`. ```bash Apple clang version 12.0.5 (clang-1205.0.22.9) Target: x86_64-apple-darwin20.4.0 error: option 'cf-protection=return' cannot be specified on this target error: option 'cf-protection=branch' cannot be specified on this target 2 errors generated. ``` ACKs for top commit: promag: Tested ACK 3caedb4. Tree-SHA512: 8763a5b94000016b0c2f0438e66002fdfcd2cbafd9d2d2acc1972f0c6f707e820186711dbd9d3f72673c179718da75588acb4732f8d84b85f0c1dfc862b6e944
PastaPastaPasta
pushed a commit
to PastaPastaPasta/dash
that referenced
this pull request
Sep 24, 2021
7e2a989 depends: latest config.sub (2021-04-30) (fanquake) f16d4cd depends: latest config.guess (2021-05-24) (fanquake) Pull request description: This is split out of bitcoin#21851. Updating these files should be mechanical, and shouldn't have to wait for that PR. Also, having support in depends for the new `arm-apple-darwin` target (added in [2593751ef276497e312d7c4ce7fd049614c7bf80](https://git.savannah.gnu.org/cgit/config.git/commit/?id=2593751ef276497e312d7c4ce7fd049614c7bf80)) is useful when debugging. i.e bitcoin#22070. If you try and compile depends for a `arm-apple-darwin` target using master, on a x86_64 darwin machine, currently you'll get: ```bash gmake -C depends -j9 HOST=arm64-apple-darwin Invalid configuration `arm64-apple-darwin': machine `arm64-apple' not recognized shasum: hosts/.mk: No such file or directory <omitted> Makefile:111: hosts/.mk: No such file or directory gmake: *** No rule to make target 'hosts/.mk'. Stop. ``` ACKs for top commit: laanwj: ACK 7e2a989 Tree-SHA512: 8ed99b5d486c6cbca8929a752460338b6ee17f6bf93013c76589605678853c3a01ebd631b4d3f5d6aaeb6e5c21b7bbe39afc4454d3a697fafb27678f6d2c021e
gwillen
pushed a commit
to ElementsProject/elements
that referenced
this pull request
Jun 1, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After two reports on IRC of issues building depends on an Apple M1 machine, this option (obviously) can't be used when targeting
arm-apple-darwin. For now, just use it forx86_64-apple-darwin.