test: fix, restore and improve cnetaddr scoped id documentation #21961
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
laanwj
reviewed
May 17, 2021
| // which does not support scoped ids and instead returns the address in a | ||
| // different format as "fe80:0:0:0:0:0:0:1" without the zone id. | ||
| const std::string link_local{"fe80::1"}; | ||
| const std::string scoped_addr{link_local + "%32"}; |
Member
There was a problem hiding this comment.
I don't really know this code but isn't the "e.g. 32" comment still relevant to this line?
Member
Author
Member
Author
|
Closing as we no longer return any scoped ids. There is still a line of orphaned documentation but probably no one will notice. |
laanwj
added a commit
that referenced
this pull request
May 19, 2021
6c280ad net: Return IPv6 scope id in `CNetAddr::ToStringIP()` (W. J. van der Laan) Pull request description: If a scope id is provided, return it back in the string representation. Also bring back the test (now in platform independent fashion). Closes #21982. Includes #21961 (apart from the MacOS remark). ACKs for top commit: practicalswift: cr ACK 6c280ad Tree-SHA512: 77792c35679b6c3545fd3a8d3d74c4f515ac2ee9f02d983251aeaaac715d55c122bbb0141abbeac272011f15520b439bd2db4ec8541a58df9b366921d212ca5f
sidhujag
pushed a commit
to syscoin/syscoin
that referenced
this pull request
May 19, 2021
…IP()` 6c280ad net: Return IPv6 scope id in `CNetAddr::ToStringIP()` (W. J. van der Laan) Pull request description: If a scope id is provided, return it back in the string representation. Also bring back the test (now in platform independent fashion). Closes bitcoin#21982. Includes bitcoin#21961 (apart from the MacOS remark). ACKs for top commit: practicalswift: cr ACK 6c280ad Tree-SHA512: 77792c35679b6c3545fd3a8d3d74c4f515ac2ee9f02d983251aeaaac715d55c122bbb0141abbeac272011f15520b439bd2db4ec8541a58df9b366921d212ca5f
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BOOST_CHECKincnetaddr_basic#21689BOOST_CHECKincnetaddr_basic#21689 and improves it with information proposed in test: use higher value and per-platform assert in cnetaddr link-local test #21690, which also tested it