test: Misc refactor to get rid of &foo[0] raw pointers #21840
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
May 3, 2021 11:50
The same loop is used by the server, so no need for the tests to do this differently.
It does not matter if the tests fail due to a BOOST_CHECK failure or due to a thrown exception. Prefer the exception because it is less code. Example fail with the throwing accessor: unknown location(0): fatal error: in "script_standard_tests/script_standard_ExtractDestinations": std::bad_variant_access: std::get: wrong index for variant test/script_standard_tests.cpp(314): last checkpoint *** 1 failure is detected in the test module "Bitcoin Core Test Suite"
maflcko
changed the title
Contributor
|
Concept ACK |
Contributor
Member
Author
It should be equally strict. Both would pass/fail the unit tests under the same conditions. |
Contributor
|
Agreed, thanks. |
Contributor
|
cr ACK fa8a888 |
promag
reviewed
May 4, 2021
|
|
||
| static const CRPCCommand vRPCCommands[] = { | ||
| {"test", &rpcNestedTest_rpc}, | ||
| {"rpcNestedTest", &rpcNestedTest_rpc}, |
Contributor
There was a problem hiding this comment.
nit, change to category seems unnecessary.
Member
Author
There was a problem hiding this comment.
Ah right. 🤦 I thought this is the name and needs to be adjusted, but yeah. Going to leave as is, because it doesn't matter.
sidhujag
pushed a commit
to syscoin/syscoin
that referenced
this pull request
May 4, 2021
…inters fa8a888 bench: Remove duplicate constants (MarcoFalke) 000098f test: Use throwing variant accessor (MarcoFalke) fa2197c test: Use loop to register RPCs (MarcoFalke) Pull request description: Simplify test code ACKs for top commit: Empact: Code Review ACK fa8a888 practicalswift: cr ACK fa8a888 promag: Code review ACK fa8a888. Tree-SHA512: 6a5bebaa9a3f43e9c332f4fbff606e9ece6dc8b95a769980082cc022f8e9bde6083c1e4a0145dcbf3741f514d6e97b4198f201a1bf1370ebf43bd3a5c0f85981
gwillen
pushed a commit
to ElementsProject/elements
that referenced
this pull request
Jun 1, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Simplify test code