Skip to content

doc: note that brew install qt6 is not supported #21791

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
raulsiles wants to merge 4 commits into from
Closed

doc: note that brew install qt6 is not supported #21791

raulsiles wants to merge 4 commits into from

Conversation

@raulsiles
Copy link
Contributor

@raulsiles raulsiles commented Apr 28, 2021 •
edited
Loading

Ensure 'qt' v6.x is not installed in brew to force the use to 'qt@5'.

@raulsiles
QT build errors with 'qt' v6.x
9e2939c 
Ensure 'qt' v6.x is not installed in brew to force the use to 'qt@5'.
@fanquake fanquake added the Docs label Apr 28, 2021
jarolrod
jarolrod reviewed Apr 28, 2021
View reviewed changes
Copy link
Contributor

@jarolrod jarolrod left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this note would be ok to add, would prevent any issues from being filed about this in the case someone accidentally installs the qt package over qt@5.

@raulsiles
Copy link
Contributor Author

raulsiles commented Apr 28, 2021

I think this note would be ok to add, would prevent any issues from being filed about this in the case someone accidentally installs the qt package over qt@5.

Not only accidentally. Other brew packages might require 'qt' (v6.x) and, as a result, it could be already installed.

raulsiles and others added 3 commits April 28, 2021 13:39
@raulsiles @jarolrod
Update doc/build-osx.md
2996252 
Co-authored-by: Jarol Rodriguez <[email protected]>
@raulsiles @jarolrod
Apply suggestions from code review
ab72652 
Co-authored-by: Jarol Rodriguez <[email protected]>
@raulsiles
Update build-osx.md
90752f8 
Removed trailing whitespace for linter.
@fanquake fanquake changed the title QT build errors with 'qt' v6.x doc: note that brew install qt6 is not supported Apr 28, 2021
@fanquake
Copy link
Member

fanquake commented Apr 28, 2021

Please squash your commits. Use a commit message like doc: note that brew installed qt is not supported, not the GitHub default message.

@raulsiles
Copy link
Contributor Author

raulsiles commented Apr 28, 2021

Please squash your commits. Use a commit message like doc: note that brew installed qt is not supported, not the GitHub default message.

I cannot squash these commits from the GitHub web interface as a contributor (and it will take me some time to switch and setup the repo in the CLI). Please, feel free to squash them directly when merging the pull request as an authorized user. Thanks!

@hebasto
Copy link
Member

hebasto commented Apr 28, 2021

Concept ACK.

Indeed, only qt@5 package must be installed, because parallel installation of qt@6 will mess /usr/local/include/ and /usr/local/lib/ directories.

@RandyMcMillan
Copy link
Contributor

RandyMcMillan commented Apr 28, 2021

Squashed:

RandyMcMillan@c5175a9

@jarolrod
Copy link
Contributor

jarolrod commented May 3, 2021

@raulsiles If you don't want to squash this or can't, you can close this and I'll pick this up for you.

@DrahtBot
Copy link
Contributor

DrahtBot commented May 3, 2021

🕵️ @harding has been requested to review this pull request as specified in the REVIEWERS file.

@laanwj
Copy link
Member

laanwj commented May 10, 2021

Is there a specific reason why our build system cannot handle qt5 and qt6 being both installed? Sure, uninstalling qt6 is a valid workaround but this seems like something that could cause problems if the user is also building things against Qt 6.

@hebasto
Copy link
Member

hebasto commented May 10, 2021

Is there a specific reason why our build system cannot handle qt5 and qt6 being both installed?

I assume the reason is sharing /usr/local/include/ and /usr/local/lib/ directories by both qt5 and qt6 installations.

@jarolrod jarolrod mentioned this pull request May 18, 2021
Merged
@fanquake fanquake closed this May 18, 2021
laanwj added a commit that referenced this pull request May 18, 2021
@laanwj
Merge #21988: doc: note that brew installed qt is not supported
2fa3f30 
33b0b26 doc: note that brew installed qt is not supported (Raul Siles)

Pull request description:

  picking up #21791, the author has stated they [cannot squash](#21791 (comment)).

  This is a useful note to prevent any issues from being opened up about this. The reason that both cannot co-exist and build bitcoin is stated [here](#21791 (comment)):
  > ... the reason is sharing /usr/local/include/ and /usr/local/lib/ directories by both qt5 and qt6 installations.

  Changes from original PR:
  - slightly move the note up in this section, this placement seems more appropriate to me
  - drop "Note:"

  [PR Render](https://github.com/jarolrod/bitcoin/blob/33b0b26a03a401bd39b88931b69d162c3c538d31/doc/build-osx.md#qt)

ACKs for top commit:
  laanwj:
    LGTM ACK 33b0b26
  hebasto:
    ACK 33b0b26

Tree-SHA512: f9efac1921a7a33b5791a9f9f4bada4b5369d358fc42e9884c077bfb4dc3f273fdd4432ce012006a8009dfafb87e13bddd56c6336fe84b6133f4b22f849c289a
sidhujag pushed a commit to syscoin/syscoin that referenced this pull request May 19, 2021
@laanwj
Merge bitcoin#21988: doc: note that brew installed qt is not supported
c9df31a 
33b0b26 doc: note that brew installed qt is not supported (Raul Siles)

Pull request description:

  picking up bitcoin#21791, the author has stated they [cannot squash](bitcoin#21791 (comment)).

  This is a useful note to prevent any issues from being opened up about this. The reason that both cannot co-exist and build bitcoin is stated [here](bitcoin#21791 (comment)):
  > ... the reason is sharing /usr/local/include/ and /usr/local/lib/ directories by both qt5 and qt6 installations.

  Changes from original PR:
  - slightly move the note up in this section, this placement seems more appropriate to me
  - drop "Note:"

  [PR Render](https://github.com/jarolrod/bitcoin/blob/33b0b26a03a401bd39b88931b69d162c3c538d31/doc/build-osx.md#qt)

ACKs for top commit:
  laanwj:
    LGTM ACK 33b0b26
  hebasto:
    ACK 33b0b26

Tree-SHA512: f9efac1921a7a33b5791a9f9f4bada4b5369d358fc42e9884c077bfb4dc3f273fdd4432ce012006a8009dfafb87e13bddd56c6336fe84b6133f4b22f849c289a
@bitcoin bitcoin locked as resolved and limited conversation to collaborators Aug 18, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

2 more reviewers

@adamjonas adamjonas adamjonas left review comments

@jarolrod jarolrod jarolrod left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

Docs

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

8 participants

@raulsiles @fanquake @hebasto @RandyMcMillan @jarolrod @DrahtBot @laanwj @adamjonas