refactor: Make MempoolAcceptResult members const #21783
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
ACK 363df75 |
Member
Author
|
The comments being addressed were from @MarcoFalke and @ariard |
Contributor
|
cr ACK 363df75: patch looks correct and |
maflcko
changed the title
sidhujag
pushed a commit
to syscoin/syscoin
that referenced
this pull request
Apr 28, 2021
363df75 doc/style followups in MempoolAcceptResult (glozow) Pull request description: Follow up to bitcoin#21062. Was going to be a part of bitcoin#20833 but I'm trying to break it down as much as possible. - Make members const (bitcoin#21062 (comment)) - List fee units (bitcoin#21062 (comment)) - Use default value for `TxValidationState` in the success case (bitcoin#21062 (comment)). ACKs for top commit: jnewbery: ACK 363df75 practicalswift: cr ACK 363df75: patch looks correct and `const` is better than non-`const` (where possible :)) ariard: Code Review ACK 363df75 Tree-SHA512: 0ff1a0279e08e03204e48d0f4c92428d7f39c32f52c1d20fe6a0283d605839898297344be82ca69640ba9f878ca4ebd5da2d717e26d719a183b211d709334082
gwillen
pushed a commit
to ElementsProject/elements
that referenced
this pull request
Jun 1, 2022
Fabcien
pushed a commit
to Bitcoin-ABC/bitcoin-abc
that referenced
this pull request
Jul 23, 2022
Summary: This is a backport of [[bitcoin/bitcoin#21783 | core#21783]] Test Plan: `ninja all check-all` Reviewers: #bitcoin_abc, Fabien Reviewed By: #bitcoin_abc, Fabien Differential Revision: https://reviews.bitcoinabc.org/D11794
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up to #21062. Was going to be a part of #20833 but I'm trying to break it down as much as possible.
TxValidationStatein the success case (refactor: return MempoolAcceptResult from ATMP #21062 (comment)).