Skip to content

Conversation

@laanwj
Copy link
Member

@laanwj laanwj commented Apr 20, 2021

It looks like #21238 introduced a silent merge conflict in the documentation, which fails with -Wdocumentation in the CI.

(please merge only if CI passes)

It looks like bitcoin#21238 introduced a silent merge conflict in the
documentation, which fails with `-Wdocumentation` in the CI.
@laanwj laanwj added the Docs label Apr 20, 2021
@maflcko
Copy link
Member

maflcko commented Apr 20, 2021

ACK if green

1 similar comment
@Sjors
Copy link
Member

Sjors commented Apr 20, 2021

ACK if green

@ajtowns
Copy link
Contributor

ajtowns commented Apr 20, 2021

ACK e5faec6 -- fixed it for me

Copy link
Contributor

@meshcollider meshcollider left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK e5faec6 modulo CI

@maflcko
Copy link
Member

maflcko commented Apr 20, 2021

Only looked at the nowallet task:

This pull: Green 🚀

@maflcko maflcko merged commit 572b36d into bitcoin:master Apr 20, 2021
@hebasto
Copy link
Member

hebasto commented Apr 20, 2021

FWIW, -Wdocumentation is activated only when --enable-suppress-external-warnings.

That is the reason why I'm suggesting to --enable-suppress-external-warnings by default.

sidhujag pushed a commit to syscoin/syscoin that referenced this pull request Apr 20, 2021
…n descriptor.cpp

e5faec6 doc: Fix doxygen comment silent merge conflict in descriptor.cpp (W. J. van der Laan)

Pull request description:

  It looks like bitcoin#21238 introduced a silent merge conflict in the documentation, which fails with `-Wdocumentation` in the CI.

  (please merge only if CI passes)

ACKs for top commit:
  ajtowns:
    ACK e5faec6 -- fixed it for me
  meshcollider:
    ACK e5faec6 modulo CI

Tree-SHA512: b07d50fd12aa7c239a92aad8ef29f4e88583c3ce701ebedba7c426aac4981c79113adc4670b7d055ab9535a28bdc3f9a30e6ca1b1ed0d7b9a333a3d9c4b40d8a
sidhujag pushed a commit to syscoin/syscoin that referenced this pull request Apr 20, 2021
gwillen pushed a commit to ElementsProject/elements that referenced this pull request Jun 1, 2022
@bitcoin bitcoin locked as resolved and limited conversation to collaborators Aug 16, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants