refactor: add [[noreturn]] attribute where applicable #21633
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Concept ACK |
fanquake
force-pushed
the
build_with_noreturn
branch
from
122b6e5 to
d154478
Compare
vasild
approved these changes
Apr 9, 2021
Contributor
vasild
left a comment
vasild
left a comment
There was a problem hiding this comment.
ACK d1544784e972918a3a7d803bae55e5a4743fbf27
nit: s/attributes/attribute/ in the commit message, it is just one addition :)
I think extending --suppress-external-warnings to cover leveldb is ok - that code is not in our control, low quality there should not drag Bitcoin Core quality down. And --suppress-external-warnings is optional.
fanquake
force-pushed
the
build_with_noreturn
branch
from
d154478 to
003929c
Compare
Member
Author
Fixed.
I'll look at doing this. We are probably also overdue for a leveldb subtree update. |
vasild
approved these changes
Apr 13, 2021
sidhujag
pushed a commit
to syscoin/syscoin
that referenced
this pull request
Apr 13, 2021
…cable 003929c refactor: add [[noreturn]] attribute where applicable (fanquake) Pull request description: Similar to bitcoin#10843. We could build with `-Wmissing-noreturn`, however that would also mean modifying something like `--suppress-external-warnings` to suppress warnings for leveldb, which I don't think we want to do. In any case, the functions where this is applicable are only added/removed very rarely. ACKs for top commit: vasild: ACK 003929c Tree-SHA512: 33dfa6547d6b84f38a941f24d4c2effe8fde7b93dbc0b27a9309716420e4a879fdbe689d789fa5439d65f5f78292f89fd9dc1b61c97acf69316dfed954086705
PastaPastaPasta
pushed a commit
to PastaPastaPasta/dash
that referenced
this pull request
Jul 1, 2021
…cable 003929c refactor: add [[noreturn]] attribute where applicable (fanquake) Pull request description: Similar to bitcoin#10843. We could build with `-Wmissing-noreturn`, however that would also mean modifying something like `--suppress-external-warnings` to suppress warnings for leveldb, which I don't think we want to do. In any case, the functions where this is applicable are only added/removed very rarely. ACKs for top commit: vasild: ACK 003929c Tree-SHA512: 33dfa6547d6b84f38a941f24d4c2effe8fde7b93dbc0b27a9309716420e4a879fdbe689d789fa5439d65f5f78292f89fd9dc1b61c97acf69316dfed954086705
PastaPastaPasta
pushed a commit
to PastaPastaPasta/dash
that referenced
this pull request
Jul 16, 2021
…cable 003929c refactor: add [[noreturn]] attribute where applicable (fanquake) Pull request description: Similar to bitcoin#10843. We could build with `-Wmissing-noreturn`, however that would also mean modifying something like `--suppress-external-warnings` to suppress warnings for leveldb, which I don't think we want to do. In any case, the functions where this is applicable are only added/removed very rarely. ACKs for top commit: vasild: ACK 003929c Tree-SHA512: 33dfa6547d6b84f38a941f24d4c2effe8fde7b93dbc0b27a9309716420e4a879fdbe689d789fa5439d65f5f78292f89fd9dc1b61c97acf69316dfed954086705
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Similar to #10843. We could build with
-Wmissing-noreturn, however that would also mean modifying something like--suppress-external-warningsto suppress warnings for leveldb, which I don't think we want to do. In any case, the functions where this is applicable are only added/removed very rarely.