Skip to content

doc: Fix typos from codespell #21626

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
fanquake merged 1 commit into from
Apr 8, 2021
Merged

doc: Fix typos from codespell #21626

fanquake merged 1 commit into from
Apr 8, 2021

Conversation

@yerzhan7
Copy link
Contributor

@yerzhan7 yerzhan7 commented Apr 6, 2021 •
edited
Loading

Typos from codespell linter: https://cirrus-ci.com/task/6677401661865984?logs=lint#L856

  • txrequest.cpp: annoucements ==> announcements
  • contrib/guix/README.md:298: stil ==> still
  • contrib/guix/guix-build:18: invokable ==> invocable
  • contrib/guix/libexec/prelude.bash:12: invokable ==> invocable
  • src/test/fuzz/tx_pool.cpp:37: acess ==> access
  • src/txorphanage.h:29: orginating ==> originating

@sipa
Copy link
Member

sipa commented Apr 6, 2021

ACK aaf59bb614f76a1795b641de064dce7e3c0552b3

1 similar comment
@maflcko
Copy link
Member

maflcko commented Apr 6, 2021

ACK aaf59bb614f76a1795b641de064dce7e3c0552b3

@maflcko
Copy link
Member

maflcko commented Apr 6, 2021 •
edited
Loading

If you want, you can also fix the other typos: https://cirrus-ci.com/task/6677401661865984?logs=lint#L856

contrib/guix/README.md:298: stil ==> still
contrib/guix/guix-build:18: invokable ==> invocable
contrib/guix/libexec/prelude.bash:12: invokable ==> invocable
src/test/fuzz/tx_pool.cpp:37: acess ==> access
src/txorphanage.h:29: orginating ==> originating
^ Warning: codespell identified likely spelling errors. Any false positives? Add them to the list of ignored words in test/lint/lint-spelling.ignore-words.txt

@yerzhan7 yerzhan7 changed the title trivial: Fix typo in txrequest.cpp comment trivial: Fix typos from codespell Apr 6, 2021
@yerzhan7
Copy link
Contributor Author

yerzhan7 commented Apr 6, 2021

If you want, you can also fix the other typos: https://cirrus-ci.com/task/6677401661865984?logs=lint#L856

Done: https://cirrus-ci.com/task/4748069938921472?logs=lint#L857

Thanks for reviewing!

@fanquake fanquake changed the title trivial: Fix typos from codespell doc: Fix typos from codespell Apr 6, 2021
jarolrod
jarolrod reviewed Apr 6, 2021
View reviewed changes
Copy link
Contributor

@jarolrod jarolrod left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK 447762cb22ae47f79371983ca64704196b313d9c

one small nit, can ignore if you'd like

contrib/guix/README.md Outdated
Copy link
Contributor

@jarolrod jarolrod Apr 6, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit, could just remove still

Suggested change
If the single-threaded rebuild still did not succeed, you may need to dig deeper.
If the single-threaded rebuild did not succeed, you may need to dig deeper.

Copy link
Contributor

@jarolrod jarolrod Apr 7, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

addressed in 94c7dd9

@fanquake
Copy link
Member

fanquake commented Apr 6, 2021

When you've finished making changes, please squash your commits. Also remove trivial: from the commit message, you can use doc: instead.

@hebasto
Copy link
Member

hebasto commented Apr 7, 2021

iiuc, the typo in annoucements is catched by @yerzhan7, not by our linter, right?

@jarolrod
Copy link
Contributor

jarolrod commented Apr 7, 2021 •
edited
Loading

iiuc, the typo in annoucements is catched by @yerzhan7, not by our linter, right?

@hebasto Yes, I think so. the branch referenced in the log is on the latest master commit. The lint did not pick it up. Also doesn't show on a more primitive branch, for example: https://cirrus-ci.com/task/5489261035126784?logs=lint#L856

@yerzhan7
Copy link
Contributor Author

yerzhan7 commented Apr 7, 2021

When you've finished making changes, please squash your commits. Also remove trivial: from the commit message, you can use doc: instead.

Done! Thanks

@practicalswift
Copy link
Contributor

practicalswift commented Apr 7, 2021

cr ACK 94c7dd9: thnaks fro fiixng tpyos!

@jarolrod
Copy link
Contributor

jarolrod commented Apr 7, 2021

ACK 94c7dd9

@fanquake fanquake merged commit 2e9031f into bitcoin:master Apr 8, 2021
@bitcoin bitcoin locked and limited conversation to collaborators Apr 8, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer

@jarolrod jarolrod jarolrod left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

Docs

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

8 participants

@yerzhan7 @sipa @maflcko @fanquake @hebasto @jarolrod @practicalswift @DrahtBot