Skip to content

Conversation

@maflcko
Copy link
Member

@maflcko maflcko commented Mar 30, 2021

Some small refactors to remove unused and redundant fuzz code

@practicalswift
Copy link
Contributor

cr ACK faa8b2de6b9749d33b4f11155a29d7094f23a144: patch looks correct and touches only src/test/fuzz/ (+ one addition to src/test/util/)

Thanks for cleaning up!

@maflcko maflcko force-pushed the 2103-fuzzCleanups branch from faa8b2d to faaf133 Compare March 30, 2021 08:19
@practicalswift
Copy link
Contributor

cr re-ACK faaf133e4ada4a12783e7395a17f207f7d700e09

… target

Can be reviewed with --color-moved=dimmed-zebra
@maflcko maflcko force-pushed the 2103-fuzzCleanups branch from faaf133 to fa4926c Compare March 30, 2021 08:43
@maflcko
Copy link
Member Author

maflcko commented Mar 30, 2021

@practicalswift
Copy link
Contributor

cr re-ACK fa4926c

@maflcko maflcko merged commit 267b60f into bitcoin:master Mar 30, 2021
sidhujag pushed a commit to syscoin/syscoin that referenced this pull request Mar 30, 2021
@maflcko maflcko deleted the 2103-fuzzCleanups branch April 1, 2021 05:59
maflcko pushed a commit to bitcoin-core/gui that referenced this pull request May 19, 2021
…e CheckTxInputs

fae4ee5 fuzz: Add missing CheckTransaction before CheckTxInputs (MarcoFalke)
faacb7e fuzz: Sanity check result of CheckTransaction (MarcoFalke)

Pull request description:

  This bug was introduced by myself in commit eeee8f5 (bitcoin/bitcoin#21553)

  Reproducer: https://github.com/bitcoin/bitcoin/files/6492249/clusterfuzz-testcase-minimized-coins_view-6109460079706112.log

  Hopefully fixes https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=34301

ACKs for top commit:
  practicalswift:
    cr ACK fae4ee5: patch looks correct :)

Tree-SHA512: 9ece7a5c4bfa60f5e5ffeba3f0ee52a07944c9bd6102588dd7ff7405695e6b32449945b7c41bd25baf38814df5a2436521e655ceff87223ad03c69ed39053023
@bitcoin bitcoin locked as resolved and limited conversation to collaborators Aug 16, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants