Implement BIP8 lockinontimeout #21507
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Anthony Towns <[email protected]>
Co-authored-by: Anthony Towns <[email protected]>
As thresholds are now parameterized, nRuleChangeActivationThreshold is no longer the threshold used for activating new rule changes. Instead it is now only used to warn if there is an unkonwn versionbits deployment. To make this clear, rename to m_vbits_min_threshold and update the comment describing it. Additionally, because this is just a minimum used for a warning, reduce the threshold to 75% so that future soft forks which may have thresholds lower than 95% will still have warnings.
-BEGIN VERIFY SCRIPT- sed -i -e 's/\bBIP9\b/versionbits/g; s/BIP9/VBits/g; s/bip9\([.()]\)/deployment_details\1/g' $(git grep -il BIP9 src) -END VERIFY SCRIPT-
Co-authored-by: Anthony Towns <[email protected]>
Since lockinontimeout for any deployment on any network should be configurable, this is added as a new command line option specifically for configuring lockinontimeout.
Co-authored-by: Luke Dashjr <[email protected]> Co-authored-by: Anthony Towns <[email protected]>
Contributor
|
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers. ConflictsReviewers, this pull request conflicts with the following ones:
If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first. |
This was referenced Mar 22, 2021
This was referenced Mar 23, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements the lockinontimeout parameter and MUST_SIGNAL phase of BIP 8, along with some tests. This PR is largely the non-refactor portions of #19573.
Additionally the lockinontimeout parameter is made configurable through a
-vblotcommand line option as has been suggested by many people. Note that no attempt is made to have lockinontimeout=true or lockinontimeout=false nodes try to find peers with the same policy. However nodes that set-vblotwill have a user agent comment indicating this.Built on #21392 for the change to height based version bits, and #21399 for the renames.