bugfix: fix bech32_encode calls in gen_key_io_test_vectors.py #21471
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fanquake
approved these changes
Mar 19, 2021
Member
fanquake
left a comment
fanquake
left a comment
There was a problem hiding this comment.
ACK 5c0210e
bitcoin/test/functional/test_framework/segwit_addr.py
Lines 54 to 57 in 8ec881d
This was referenced Mar 19, 2021
Contributor
|
ACK 5c0210e Sorry for not catching this! |
maflcko
pushed a commit
that referenced
this pull request
Apr 1, 2021
…dresses (0.21 backport) f2195d7 Backport invalid address tests (Pieter Wuille) 1e96711 naming nits (Fabian Jahr) 7dfe406 Add signet support to gen_key_io_test_vectors.py (Pieter Wuille) 593e206 Use Bech32m encoding for v1+ segwit addresses (Pieter Wuille) 8944aaa Add Bech32m test vectors (Pieter Wuille) 1485533 Implement Bech32m encoding/decoding (Pieter Wuille) Pull request description: Backport of #20861. Also includes #21471. ACKs for top commit: jnewbery: utACK f2195d7 MarcoFalke: cherry-pick re-ACK f2195d7 , only change is version number in doc/bips and new test commit 🍝 fanquake: ACK f2195d7 - performed the backport, changes look sane. Have not tested extensively. Tree-SHA512: 7dc043e44d7cda07d73331a7b49666b9db98c99f2635dab0cfeb45422dbfbe75a7b44d0aff85ef6369d412d8a5041ed0826c86ffdfc13c5fbff74adfe4d91c1a
laanwj
added a commit
that referenced
this pull request
Apr 23, 2021
…dresses (0.20 backport) c0f85fd Backport invalid address tests (Pieter Wuille) c670986 naming nits (Fabian Jahr) 1a4e88e Use Bech32m encoding for v1+ segwit addresses (Pieter Wuille) cf18ac9 Add Bech32m test vectors (Pieter Wuille) 5f9537b Implement Bech32m encoding/decoding (Pieter Wuille) Pull request description: Backport of #20861 for 0.20. Also includes #21471. ACKs for top commit: jnewbery: utACK c0f85fd MarcoFalke: range-diff-only ACK c0f85fd 🐔 Tree-SHA512: e87e52995cb9b555109bc500dba1e844993d881821d2001443b3de9e3ef9050ddb73deefa0c1af732418fa7355a86b875789887c9611c340713b3ad26809d58e
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the the calls to bech32_encode in the gen_key_io_test_vectors.py script.
Bug introduced in #20861.