Skip to content

Conversation

@hebasto
Copy link
Member

@hebasto hebasto commented Mar 16, 2021

This is a follow up of #21007.

When AC_CHECK_DECLS([fork]) fails:

$ src/bitcoind -daemonwait
Error: Error parsing command line arguments: Invalid parameter -daemonwait

  • with this PR:
$ src/bitcoind -daemonwait
Error: -daemon is not supported on this operating system

@laanwj
Copy link
Member

laanwj commented Mar 16, 2021

Good catch.
Code review ACK 4d008f9

@laanwj laanwj merged commit 01bb3af into bitcoin:master Mar 16, 2021
sidhujag pushed a commit to syscoin/syscoin that referenced this pull request Mar 16, 2021
…uments

4d008f9 Always add -daemonwait to known command line arguments (Hennadii Stepanov)

Pull request description:

  This is a follow up of bitcoin#21007.

  When `AC_CHECK_DECLS([fork])` fails:

  - on master (8e65320):
  ```
  $ src/bitcoind -daemonwait
  Error: Error parsing command line arguments: Invalid parameter -daemonwait

  ```

  - with this PR:
  ```
  $ src/bitcoind -daemonwait
  Error: -daemon is not supported on this operating system

  ```

ACKs for top commit:
  laanwj:
    Code review ACK 4d008f9

Tree-SHA512: 7fcb5e9d76958adcf57e04fa74bd2a98d62459d81a3c57a97bd74c346cbf47c53e560a15455fb024e912c3b44e8487a83499e993b282871ba069953e665d88a9
@hebasto hebasto deleted the 210316-fork branch April 20, 2021 12:59
@bitcoin bitcoin locked as resolved and limited conversation to collaborators Aug 16, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants