refactor: Pass PeerManagerImpl members only once #21425
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maflcko
force-pushed
the
2103-refactorMember
branch
from
fa4bc70 to
faa3e26
Compare
1 task
Contributor
|
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers. ConflictsReviewers, this pull request conflicts with the following ones:
If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first. |
Contributor
|
🕵️ @sipa has been requested to review this pull request as specified in the REVIEWERS file. |
Contributor
|
Concept ACK 😌 |
jnewbery
reviewed
Mar 17, 2021
Contributor
jnewbery
left a comment
jnewbery
left a comment
There was a problem hiding this comment.
utACK faa3e2685a9c200188889e35843c65ec8338132f
Can be reviewed with --word-diff-regex=. --ignore-all-space
maflcko
force-pushed
the
2103-refactorMember
branch
from
faa3e26 to
fa2a80b
Compare
Contributor
|
utACK fa2a80b |
1 similar comment
Contributor
|
utACK fa2a80b |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Member variables are already passed to methods via
this, so no need to pass them another time as function parameter.