-
Notifications
You must be signed in to change notification settings - Fork 38.7k
contrib: Make systemd invoke dependencies only when ready #21418
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
darosior
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ACK 8f249cba4101787d9f7389bdf3bbe1ed0b50a16d
hebasto
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ACK 8f249cba4101787d9f7389bdf3bbe1ed0b50a16d
Just to be sure I checked this. However we don't have a timeout configured for startup phase at all; this is
We might want to set this to |
|
Agree
|
Closes bitcoin#21322 by making bitcoind conform to behavior specified for `type=forking`.
8f249cb to
663f6cd
Compare
Thank you for checking. I have set |
darosior
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ACK 663f6cd
hebasto
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
re-ACK 663f6cd
Make systemd invoke dependencies only when ready by using
-daemonwaitin the service file instead of-daemon.Closes #21322 by making bitcoind conform to behavior specified for
type=forking.This may need some tuning of timeouts.