Skip to content

Conversation

@fyquah
Copy link
Contributor

@fyquah fyquah commented Mar 1, 2021

Found some spelling errors while running spelling linter #21245

This PR fixes them.

@practicalswift
Copy link
Contributor

practicalswift commented Mar 1, 2021

@fyquah

Luckily spelling errors cannot cause CI to fail, so the CI failure in the issue you referenced was not spelling related :)

With that said: Cnocept AKC on fiixng the speling erorrs! :)

FWIW this is the error that did cause the referenced CI failure:

This diff appears to have added new lines with trailing whitespace.
The following changes were suspected:

diff --git a/src/core_io.h b/src/core_io.h
@@ -22,0 +23,7 @@ class CTxUndo;
+
^---- failure generated from test/lint/lint-whitespace.sh

@hebasto
Copy link
Member

hebasto commented Mar 1, 2021

With that said: Cnocept AKC on fiixng the speling erorrs! :)

:)

@fyquah
Copy link
Contributor Author

fyquah commented Mar 1, 2021

diff --git a/src/core_io.h b/src/core_io.h
@@ -22,0 +23,7 @@ class CTxUndo;
+
^---- failure generated from test/lint/lint-whitespace.sh

Turns out I wasn't able to capture this because I was using a custom diff tool with git 🤔

Copy link
Member

@fanquake fanquake left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK fbbb2d4 - I thought we just fixed all of these.

@fanquake fanquake merged commit 72e6979 into bitcoin:master Mar 2, 2021
@bitcoin bitcoin locked and limited conversation to collaborators Mar 2, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants