wallet: remove lock during listaddressgroupings
#21312
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Author
|
any help with fixing CI is welcome |
Member
|
Contributor
|
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers. ConflictsReviewers, this pull request conflicts with the following ones:
If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first. |
This was referenced Mar 4, 2021
Contributor
|
🐙 This pull request conflicts with the target branch and needs rebase. Want to unsubscribe from rebase notifications on this pull request? Just convert this pull request to a "draft". |
Contributor
There hasn't been much activity lately and the patch still needs rebase. What is the status here?
|
1 similar comment
Contributor
There hasn't been much activity lately and the patch still needs rebase. What is the status here?
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently I can't see how many addresses I have, because when I do
listaddressgroupingsit locks my wallet. Because it locks the wallet I can't transfer from my wallet. Stopping the sending from wallet, is not an option for me.What I want is to see
listaddressgroupingsand be able to send from wallet at the same time.Since that, when calling
listaddressgroupingsyou have at least 2 locks that I've removed from code. I've double checked thatGetAddressBalancesnorGetAddressGroupingsis used in code in any other place except forlistaddressgroupings.