Skip to content

wallet: createwallet examples for descriptor wallets #21302

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
laanwj merged 3 commits into from
Apr 5, 2021
Merged

wallet: createwallet examples for descriptor wallets #21302

laanwj merged 3 commits into from
Apr 5, 2021

Conversation

@S3RK
Copy link
Contributor

@S3RK S3RK commented Feb 26, 2021

Rationale: make descriptor wallets more visible and just a bit easier to setup

bitcoin-cli help createwallet

Before:

Examples:
> bitcoin-cli createwallet "testwallet"
> curl --user myusername --data-binary '{"jsonrpc": "1.0", "id": "curltest", "method": "createwallet", "params": ["testwallet"]}' -H 'content-type: text/plain;' http://127.0.0.1:8332/

After

Examples:
> bitcoin-cli createwallet "testwallet"
> curl --user myusername --data-binary '{"jsonrpc": "1.0", "id": "curltest", "method": "createwallet", "params": ["testwallet"]}' -H 'content-type: text/plain;' http://127.0.0.1:8332/
> bitcoin-cli createwallet "descriptors" false false "" true true true
> curl --user myusername --data-binary '{"jsonrpc": "1.0", "id": "curltest", "method": "createwallet", "params": ["descriptors", false, false, "", true, true, true]}' -H 'content-type: text/plain;' http://127.0.0.1:8332/

@laanwj laanwj added the Docs label Feb 26, 2021
laanwj
laanwj reviewed Feb 26, 2021
View reviewed changes
@laanwj
Copy link
Member

laanwj commented Feb 26, 2021

I've implemented HelpExampleCliNamed here and used it for a createwallet example, feel free to take it over:
https://github.com/laanwj/bitcoin/tree/2021-02-namedcli-help

(I guess we can do a similar HelpExampleCliNamed)

@S3RK S3RK force-pushed the create_descriptor_help branch from 9398176 to 5039e0e Compare March 3, 2021 09:07
@DrahtBot
Copy link
Contributor

DrahtBot commented Mar 3, 2021 •
edited
Loading

The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

Conflicts

Reviewers, this pull request conflicts with the following ones:

If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.

This was referenced Mar 3, 2021
Closed
Closed
@S3RK S3RK requested a review from laanwj April 2, 2021 17:16
laanwj
laanwj approved these changes Apr 5, 2021
View reviewed changes
Copy link
Member

@laanwj laanwj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested ACK 5039e0e

@laanwj laanwj merged commit 5c9b06d into bitcoin:master Apr 5, 2021
sidhujag pushed a commit to syscoin/syscoin that referenced this pull request Apr 5, 2021
@laanwj
Merge bitcoin#21302: wallet: createwallet examples for descriptor wal…
fe20373 
…lets
@luke-jr luke-jr mentioned this pull request Jul 7, 2021
Closed
@Vilasinee99 Vilasinee99 mentioned this pull request Feb 5, 2022
Closed
@bitcoin bitcoin locked as resolved and limited conversation to collaborators Aug 18, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@laanwj laanwj laanwj approved these changes

Assignees

No one assigned

Labels

Docs Wallet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@S3RK @laanwj @DrahtBot @fanquake