Skip to content

break after ProcessMessage() to give other peers a chance. #2125

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
rebroad wants to merge 1 commit into from
Closed

break after ProcessMessage() to give other peers a chance. #2125

rebroad wants to merge 1 commit into from

Conversation

@rebroad
Copy link
Contributor

@rebroad rebroad commented Dec 23, 2012

This is to help with nodes becoming unresponsive in the eyes of other nodes. Also, in combination with my other pulls, this helps to reduce the number of duplicate blocks received.

@BitcoinPullTester
Copy link

BitcoinPullTester commented Dec 23, 2012

Automatic sanity-testing: PASSED, see http://jenkins.bluematt.me/pull-tester/7f49bfde58ddf53611229ae2e0215fbea3b1425b for binaries and test log.

1 similar comment
@BitcoinPullTester
Copy link

BitcoinPullTester commented Jan 24, 2013

Automatic sanity-testing: PASSED, see http://jenkins.bluematt.me/pull-tester/7f49bfde58ddf53611229ae2e0215fbea3b1425b for binaries and test log.

@sipa
Copy link
Member

sipa commented Apr 13, 2013

Can you test whether this is still needed, after the recent network changes?

@jgarzik
Copy link
Contributor

jgarzik commented Apr 13, 2013

It seems unneeded, AFAICS

@sipa
Copy link
Member

sipa commented Apr 13, 2013

Yes, I also don't see what this should help with, but rebroad seems to have unusual network problems of some sort, so I still wonder whether perhaps those improved because of the recent network changes.

@rebroad
Copy link
Contributor Author

rebroad commented May 12, 2013

@sipa yes, this still is useful after your network changes. This patch is still providing me with valuable functionality - especially when combined with #1382

@sipa
Copy link
Member

sipa commented May 12, 2013

Can you explain what exact difference in behaviour you notice?

@jgarzik
Copy link
Contributor

jgarzik commented May 30, 2013

@rebroad Agree w/ @sipa. Please explain precisely what behavior differences and problems are being seen.

"still useful" is insufficient :)

@jgarzik
Copy link
Contributor

jgarzik commented Jun 19, 2013

Closing. Happy to reopen, if behavior differences can be specifically quantified.

@jgarzik jgarzik closed this Jun 19, 2013
@rebroad rebroad mentioned this pull request Feb 17, 2014
Merged
@rebroad rebroad deleted the BreakAfterProcessMessage branch February 17, 2014 00:31
@bitcoin bitcoin locked as resolved and limited conversation to collaborators Sep 8, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@rebroad @BitcoinPullTester @sipa @jgarzik