Fix off-by-one error: change outputs were never last #2120
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Found by Hal Finney (thanks Hal!): change outputs were never inserted as the last output, so were not randomized at all for single-output transactions (they were always the first output). Fixes issue bitcoin#2107
Contributor
Author
|
Tested in a testnet-in-a-box setup, sent 10 random 1-ouput transactions (sendtoaddress) and 10 random 2-output transactions (sendmany), then used getrawtransaction to make sure the change outputs were random. |
|
Automatic sanity-testing: PASSED, see http://jenkins.bluematt.me/pull-tester/b68208178884d006d16cd0712a89b7abf3e32fbd for binaries and test log. |
owlhooter
pushed a commit
to owlhooter/mazacoin-new
that referenced
this pull request
Oct 11, 2018
* Fix typo in PS info dialog Also adjust translations accordingly. * Fix typo in PS low key warning * Fix typo in sendrawtransaction help * Fix sendtoaddress/sendmany help text * Fix listreceivedby* help text * Fix typo in listunspent help * Fix spelling "recieves"->"receives" Shame on me * transactions->transaction * receives->"incoming payments grouped"
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Found by Hal Finney (thanks Hal!): change outputs were never
inserted as the last output, so were not randomized at all
for single-output transactions (they were always the first output).
Fixes issue #2107