Skip to content

Conversation

@hebasto
Copy link
Member

@hebasto hebasto commented Feb 8, 2021

Fuzz binary is not shipped to users.
This PR saves hundreds MB of the disk space for containers.

@maflcko
Copy link
Member

maflcko commented Feb 8, 2021

Missing the same change for guix?

@hebasto
Copy link
Member Author

hebasto commented Feb 8, 2021

Missing the same change for guix?

🤦‍♂️
Updated.

@hebasto hebasto changed the title build: Disable --disable-fuzz-binary for gitian builds build: Disable --disable-fuzz-binary for gitian/guix builds Feb 8, 2021
@maflcko
Copy link
Member

maflcko commented Feb 8, 2021

review ACK cb151b7

While it is useful to sometimes have easy access to bench_bitcoin or the fuzz binary compiled with the release-build-system for testing purposes, I can see that shipping them does cost a lot of bandwidth.

@fanquake
Copy link
Member

fanquake commented Feb 9, 2021

ACK cb151b7

@fanquake fanquake merged commit a0077a8 into bitcoin:master Feb 9, 2021
@hebasto hebasto deleted the 210208-fuzz branch February 9, 2021 09:08
sidhujag pushed a commit to syscoin/syscoin that referenced this pull request Feb 9, 2021
@DrahtBot
Copy link
Contributor

Gitian builds

File commit b09ad73
(master)
commit 122096205199ddf19a8459f78bb652126912f8ac
(master and this pull)
*-aarch64-linux-gnu-debug.tar.gz e482e1ffb6d590e9... cc93aa93fc94ce92...
*-aarch64-linux-gnu.tar.gz df3be41b88c4078c... 541e6c80cb774adb...
*-arm-linux-gnueabihf-debug.tar.gz eb876ea32b885016... 5c417d0f5c5ad02f...
*-arm-linux-gnueabihf.tar.gz e872607ebe3d7220... ec7ab4ef75c57851...
*-osx-unsigned.dmg 6f7d0573fcf49c8c... 8dee5f020a607bdb...
*-osx64.tar.gz a63f4cea5d79ea9a... ddb24c602e1f63c7...
*-powerpc64-linux-gnu-debug.tar.gz e726677b78592a39... 3f6937cf7cc6be5a...
*-powerpc64-linux-gnu.tar.gz b6b94044ba0a5783... 7f7a18b00ae53ff6...
*-powerpc64le-linux-gnu-debug.tar.gz 92934a45fc3c59f4... 7748a77edbf21848...
*-powerpc64le-linux-gnu.tar.gz 791ecee26d39101e... 787455df8f45caf5...
*-riscv64-linux-gnu-debug.tar.gz 066f582f335c3278... 2a0efefd9d82af0d...
*-riscv64-linux-gnu.tar.gz 711987946a382246... fcb9749a904fc07d...
*-x86_64-linux-gnu-debug.tar.gz 3d8ef8a706b8b22d... 032697ef9ad92c66...
*-x86_64-linux-gnu.tar.gz 60557469235f4ff1... 8154c3f53ebaa3eb...
*.tar.gz 83052437f205ae95... cae418ac4499e7c6...
bitcoin-core-linux-22-res.yml 28293a297c8abff7... e1ae8fd93ac0ec58...
bitcoin-core-osx-22-res.yml 16f364b0d39e3c0c... 95afcc00817c1081...
linux-build.log e5e49de1b137d1d5... ebd721af6cb975c5...
osx-build.log 21cb51069c9783a3... 9d5e6d2423d5bcf5...
win-build.log d808ed3a4095152b... 9e7b067d6b1488bc...
*-win64-debug.zip ca035491c814c9b3...
*-win64-setup-unsigned.exe 21a9845956b49e84...
*-win64.zip aa055fd8ccd65fcf...
bitcoin-core-linux-22-res.yml.diff b3b753c65bd59f58...
bitcoin-core-osx-22-res.yml.diff 92d4afb112416ef8...
bitcoin-core-win-22-res.yml 1266c8fb1510f333...
linux-build.log.diff 914a879ad977d05f...
osx-build.log.diff 3b23215f6ad28432...
win-build.log.diff dd4c9d92535470bb...

@bitcoin bitcoin locked as resolved and limited conversation to collaborators Aug 18, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants