ci: use Focal for macOS cross builds #21112
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fanquake
force-pushed
the
actually_use_focal_in_cirrus_ci
branch
2 times, most recently
from
29a6b99 to
a9694c8
Compare
Member
Author
|
I've added a fix for the "wine: fixed a temporary directory error, please try running the same command again" issue. It seems that just invoking wine once before wrapping is enough to solve it. This fixes the issue, at least for me locally, when running the Windows CI using |
Member
Author
|
Seems that still wasn't enough to fix the wine issue here. Going to look at removing make: Leaving directory '/tmp/cirrus-ci-build/ci/scratch/build/bitcoin-x86_64-w64-mingw32/src/univalue'
wine-5.0 (Ubuntu 5.0-3ubuntu1)
/tmp/cirrus-ci-build/ci/scratch/build/bitcoin-x86_64-w64-mingw32/release/bitcoin-cli.exe: PE32+ executable (console) x86-64 (stripped to external PDB), for MS Windows
....
Making check in src
make[1]: Entering directory '/tmp/cirrus-ci-build/ci/scratch/build/bitcoin-x86_64-w64-mingw32/src'
make[2]: Entering directory '/tmp/cirrus-ci-build/ci/scratch/build/bitcoin-x86_64-w64-mingw32/src'
make check-TESTS check-local
make[3]: Entering directory '/tmp/cirrus-ci-build/ci/scratch/build/bitcoin-x86_64-w64-mingw32/src'
Running tests: arith_uint256_tests from test/arith_uint256_tests.cpp
Running tests: amount_tests from test/amount_tests.cpp
Running tests: addrman_tests from test/addrman_tests.cpp
make[4]: Entering directory '/tmp/cirrus-ci-build/ci/scratch/build/bitcoin-x86_64-w64-mingw32/src'
============================================================================
Testsuite summary for Bitcoin Core 21.99.0
============================================================================
# TOTAL: 0
# PASS: 0
# SKIP: 0
# XFAIL: 0
# FAIL: 0
# XPASS: 0
# ERROR: 0
============================================================================
make[4]: Leaving directory '/tmp/cirrus-ci-build/ci/scratch/build/bitcoin-x86_64-w64-mingw32/src'
Running tests: allocator_tests from test/allocator_tests.cpp
wine: created the configuration directory '/root/.wine'
wine: fixed a temporary directory error, please try running the same command again
wine: fixed a temporary directory error, please try running the same command again
make[3]: *** [Makefile:16876: test/allocator_tests.cpp.test] Error 1
make[3]: *** Waiting for unfinished jobs....
make[3]: *** [Makefile:16876: test/arith_uint256_tests.cpp.test] Error 1
wine: chdir to /tmp/wine-T4J7Vv/server-31-2397f5 : No such file or directory
wine: created the configuration directory '/root/.wine'
wine: chdir to /tmp/wine-apTpaF/server-31-2397f5 : No such file or directory
make[3]: *** [Makefile:16876: test/addrman_tests.cpp.test] Error 1
make[3]: *** [Makefile:16876: test/amount_tests.cpp.test] Error 1 |
fanquake
force-pushed
the
actually_use_focal_in_cirrus_ci
branch
3 times, most recently
from
b0f2521 to
3909652
Compare
fanquake
force-pushed
the
actually_use_focal_in_cirrus_ci
branch
from
3909652 to
ac24af4
Compare
fanquake
changed the title
Member
|
cr ACK ac24af4 |
sidhujag
pushed a commit
to syscoin/syscoin
that referenced
this pull request
Feb 9, 2021
ac24af4 ci: use Ubuntu Focal for macOS cross build (fanquake) Pull request description: I had assumed Cirrus was spinning up Docker containers to run the CI, however we are actaully running on the Cirrus machines themselves. See `DANGER_RUN_CI_ON_HOST` and in the logs: ```bash Running on host system without docker wrapper ``` So with this change we will actually be using Focal for the macOS cross build. Follow up to bitcoin#21036. This originally contained Windows changes, and an attempt to get Cirrus running without `DANGER_RUN_CI_ON_HOST`, however that seems non-trival, so Windows changes have been dropped from here for now. ACKs for top commit: MarcoFalke: cr ACK ac24af4 Tree-SHA512: 587ba5acf741bcefecf1bc262fa1177f565ebfa9de56125eca19ed3c7db7b9aabfb96866e9c140681b88cb7015a3ded2bc6b4b1b235543d6f6e9dfc6984d569f
sidhujag
pushed a commit
to syscoin/syscoin
that referenced
this pull request
Feb 9, 2021
This reverts commit cf40402.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I had assumed Cirrus was spinning up Docker containers to run the CI,
however we are actaully running on the Cirrus machines themselves. See
DANGER_RUN_CI_ON_HOSTand in the logs:So with this change we will actually be using Focal for the macOS cross build.
Follow up to #21036.
This originally contained Windows changes, and an attempt to get Cirrus running without
DANGER_RUN_CI_ON_HOST, however that seems non-trival, so Windows changes have been dropped from here for now.